-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameter object missing fields - allowEmptyValue, deprecated. #5029
Open
skywing918
wants to merge
20
commits into
microsoft:main
Choose a base branch
from
skywing918:ParameterObjectMissing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+63
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
skywing918
commented
Nov 8, 2024
- allowEmptyValue, update doc, this field is NOT RECOMMENDED, and it is likely to be removed in a later revision in OpenAPI 3.0.4
- deprecated, deprecate parameters with #deprecated
skywing918
changed the title
[WIP]Parameter object missing fields - allowEmptyValue, deprecated Do Not Review
[WIP]Parameter object missing fields - allowEmptyValue, deprecated. Do Not Review
Nov 8, 2024
wanlwanl
reviewed
Nov 8, 2024
website/src/content/docs/docs/getting-started/typespec-for-openapi-dev.md
Outdated
Show resolved
Hide resolved
…8/typespec into ParameterObjectMissing
LGTM |
wanlwanl
requested review from
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
November 12, 2024 10:05
wanlwanl
changed the title
[WIP]Parameter object missing fields - allowEmptyValue, deprecated. Do Not Review
Parameter object missing fields - allowEmptyValue, deprecated.
Nov 12, 2024
chrisradek
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some notes on the docs.
website/src/content/docs/docs/getting-started/typespec-for-openapi-dev.md
Outdated
Show resolved
Hide resolved
website/src/content/docs/docs/getting-started/typespec-for-openapi-dev.md
Outdated
Show resolved
Hide resolved
…napi-dev.md Co-authored-by: Christopher Radek <[email protected]>
…napi-dev.md Co-authored-by: Christopher Radek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.