Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable building ARM64 version of this library #211

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

Alan-Jowett
Copy link
Member

This pull request includes significant updates to the build configurations and project files to support multiple architectures (x64 and ARM64). The changes involve modifying the build matrix in GitHub Actions workflows, updating project configuration files, and ensuring conditional compilation settings for different platforms.

GitHub Actions Workflow Updates:

  • .github/workflows/build.yml: Added architecture to the build matrix and updated environment variables and commands to support both x64 and ARM64 architectures. Conditional steps were added to ensure certain tests only run on x64. [1] [2] [3] [4] [5] [6]

Project Configuration Updates:

  • Directory.Build.props: Added project configurations for Debug, Release, and FuzzerDebug for Win32, x64, and ARM64 platforms. Also included conditional compilation settings based on the platform.

Project File Updates:

sample/sample.vcxproj Outdated Show resolved Hide resolved
Copy link
Member

@nibanks nibanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the branch policy now because of the job name changes.

Alan Jowett added 2 commits September 17, 2024 08:05
@Alan-Jowett Alan-Jowett merged commit 8a3414f into microsoft:main Sep 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants