Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Azure Environment Selector #133

Open
jimseiwert opened this issue Dec 6, 2019 · 8 comments · May be fixed by #151
Open

Azure Environment Selector #133

jimseiwert opened this issue Dec 6, 2019 · 8 comments · May be fixed by #151
Labels
bug Something isn't working

Comments

@jimseiwert
Copy link

It looks like this extension is only connecting to Azure Commercial and not respecting the azure environment selector of the azure plugin. Is there anyway we can set the environment to use Azure US Government Cloud?

@joechung-msft joechung-msft added the bug Something isn't working label Dec 14, 2019
@creativekinetix
Copy link

@joechung-msft where does this change need to be made? Is it an issue with the implementation of vscode-azure-account or vscode-azuretools? If you can provide some direction that would be helpful. I'm currently trying to track down why the Logic App extension isn't respecting the selected Azure Cloud (ie: Azure Government). All other VSCode Azure extensions seem to read this properly.

Thanks,

@creativekinetix
Copy link

@joechung-msft Fixed and confirmed to be connecting to Azure Commercial and Azure US Government. Will be submitting PR shortly.

creativekinetix added a commit to creativekinetix/vscode-azurelogicapps that referenced this issue Mar 29, 2020
creativekinetix added a commit to creativekinetix/vscode-azurelogicapps that referenced this issue Mar 29, 2020
creativekinetix pushed a commit to creativekinetix/vscode-azurelogicapps that referenced this issue Mar 30, 2020
@creativekinetix
Copy link

This issue is being caused by the version of vscode-azureextensionui being used by the the extension and can't be fully resolved.

I'm able to make changes to the code and connect to logic apps in Government Cloud but none of the other commands work (ie: Create Logic App) because they rely on the ui extension which is defaulting to Azure Commercial resource manager endpoint.

@joechung-msft, are there currently any plans to update the vscode-azureextensionsui module? I was taking a look over the weekend and appears there are significant breaking changes in v0.17.0+. I would be happy to help out with this effort.

@joechung-msft
Copy link
Contributor

Will updating vscode-azureextensionui unblock progress on this? In the meantime, I have forwarded this PR to my lead and PM for them to review.

@creativekinetix
Copy link

I will cleanup and resubmit the PR. I tried making the changes to fix the wizard errors caused by vscode-azureextentsionui so I want to remove those.

As for the update, the upgrade I believe would fix this issue completely, however as I mentioned, there are significant breaking changes which appear would require a good amount of rework/rewriting because a lot of the interfaces have been moved into abstract classes with slightly different implementations etc.

I started to make the necessary changes but wanted to make sure I wasn't duplicating work if there was already an effort being made. I will share the repo once I have a working base for the upgrade. Would surely welcome input on direction etc.

Thanks!

creativekinetix added a commit to creativekinetix/vscode-azurelogicapps that referenced this issue Mar 31, 2020
creativekinetix added a commit to creativekinetix/vscode-azurelogicapps that referenced this issue Mar 31, 2020
creativekinetix pushed a commit to creativekinetix/vscode-azurelogicapps that referenced this issue Mar 31, 2020
@joechung-msft
Copy link
Contributor

You aren't duplicating work. Your effort thus far is greatly appreciated!

@creativekinetix
Copy link

@joechung-msft Good news, updating to 0.17.1 was a pretty easy lift. I just submitted a new PR. Please disregard #150 and use PR #151 instead.

Let me know if you have questions or need anything additional from me.

@jamesseiwert
Copy link

Any update on this PR #151 ? It looks like this bug is still active

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
4 participants