Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Fix Azure Environment Selector #133 #150

Closed

Conversation

creativekinetix
Copy link

@creativekinetix creativekinetix commented Mar 29, 2020

Fix #133 - Allows connection to all other Azure clouds (ie: Azure Gov) based on currently logged in environment.

@msftclas
Copy link

msftclas commented Mar 29, 2020

CLA assistant check
All CLA requirements met.

@creativekinetix
Copy link
Author

Wizard commands are still broken for Azure Government. Working to resolve.

@creativekinetix
Copy link
Author

Currently, Logic Apps and Integration Accounts are displaying in their respective views. The .json ARM templates can be opened, edited and saved. However they can not be opened in the visual editor (see below).

Still trying to narrow down the issue with the ResourceGroupListStep implementation. I've extended ResourceGroupListStep to override the built in getResourceGroups() so baseUri can be passed in but still running into same "Subscription Id {x} not found" error when trying to create a Logic App or Integration Account within VSCode.

The createAzureClient() which is used by getResourceGroups() seems to account for the baseUri, however during compile it seemed like the baseUri parameter was being dropped and not passed into the ResourceManagementClient().

Still investigating. Please let me know if we want to close this PR and re-open when work is completed.

Thanks

@creativekinetix
Copy link
Author

Closing this PR while I resolve Wizard issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Environment Selector
2 participants