Add notebook document sync infrastructure for Jupyter support#664
Draft
Add notebook document sync infrastructure for Jupyter support#664
Conversation
- Add NOTEBOOK_SYNC_OPTIONS and notebook_document_sync to LanguageServer - Add onNotebook:jupyter-notebook and onNotebook:interactive activation events - Notebook lifecycle handlers will be added separately (formatting-specific) Ref #87 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
edvilme
added
feature-request
Add NOTEBOOK_DOCUMENT_DID_* event constants and notebook-related type classes (NotebookDocumentSyncOptions, NotebookCellLanguage, etc.) to the lsprotocol.types mock so lsp_server.py can be imported in unit tests. Also update _MockLS to use Pygls 2.0 method names. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
NotebookCellLanguage(language='python') and similar calls require the mock classes to accept **kwargs in __init__. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Jupyter notebook (.ipynb) and Interactive Window support using the LSP 3.17 Notebook Document Sync protocol, following the upstream template PR microsoft/vscode-python-tools-extension-template#265 and the existing �scode-isort implementation.
Changes
package.json: AddonNotebook:jupyter-notebookandonNotebook:interactiveactivation eventsbundled/tool/lsp_server.py:NOTEBOOK_SYNC_OPTIONSconstant and wire intoLanguageServerconstructor_get_document_path()helper to resolvevscode-notebook-cell:URIs to filesystem pathsdidOpen,didChange,didSave,didClose) that publish diagnostics for Python code cellsUpstream
Ref #87