logService: feat: migrate ITracer to ILogger interface#3127
Merged
Conversation
Contributor
ulugbekna
commented
Jan 23, 2026
ulugbekna
commented
- logService: feat: migrate ITracer to ILogger interface
- tracing: migrate off of ITracer in favor of ILogService
Replace deprecated ITracer interface with ILogger across inline edits and xtab providers. Add LogTarget.fromCallback() and withExtraTarget() to ILogger for callback-based logging support previously provided by ITracer's sub() method.
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates the codebase off the deprecated ITracer API and onto the ILogService/ILogger logging interfaces, introducing an “extra target” mechanism for routing logs to additional sinks.
Changes:
- Removed
src/util/common/tracing.ts(ITracer/Tracer/createTracer) and updated call sites to useILogger.createSubLogger(...). - Extended
ILoggerwithwithExtraTarget(...)and addedLogTarget.fromCallback(...)for easy target creation. - Updated a broad set of inline edits / xtab / diagnostics components and tests to use the new logging interface.
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/common/tracing.ts | Removes legacy tracer implementation and types. |
| src/platform/log/common/logService.ts | Adds ILogger.withExtraTarget, LogTarget.fromCallback, and implementation support. |
| src/platform/log/test/common/subLogger.spec.ts | Adds unit coverage for withExtraTarget and LogTarget.fromCallback. |
| src/platform/testing/common/testLogService.ts | Updates test log service to implement withExtraTarget. |
| src/platform/inlineEdits/common/statelessNextEditProvider.ts | Replaces ITracer parameter with ILogger in provider API. |
| src/platform/inlineEdits/node/inlineEditsModelService.ts | Migrates internal tracing to ILogger sub-loggers. |
| src/extension/inlineEdits/vscode-node/jointInlineCompletionProvider.ts | Migrates tracing calls to ILogger and uses sub-loggers. |
| src/extension/inlineEdits/node/nextEditProvider.ts | Replaces tracer usage with ILogger and adds extra-target logging into request log context. |
| src/extension/inlineEdits/node/nextEditCache.ts | Updates cache tracing/rebase logging to use ILogger. |
| src/extension/inlineEdits/common/rejectionCollector.ts | Changes ctor to accept ILogService and uses ILogger sub-logger. |
| src/extension/inlineEdits/common/editRebase.ts | Updates rebase and consistency logging to use ILogger. |
| src/extension/inlineEdits/vscode-node/features/* | Migrates diagnostics providers/processors from ITracer to ILogger. |
| src/extension/xtab/node/xtabProvider.ts | Updates provider signatures to accept ILogger and replaces tracer sub-sections with sub-loggers. |
| src/extension/xtab/node/xtabNextCursorPredictor.ts | Replaces ITracer with ILogger and uses sub-loggers. |
| src//test//*.spec.ts | Updates test mocks/stubs for new ILogger surface. |
| src/extension/inlineEdits/node/serverPoweredInlineEditProvider.ts | Updates provider signature to accept ILogger. |
hediet
previously approved these changes
Jan 23, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
roblourens
previously approved these changes
Jan 25, 2026
dmitrivMS
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.