Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dev containers content #5587
Update dev containers content #5587
Changes from 5 commits
64ce2e5
9bd0d6a
14e6157
e665021
913d586
95d896c
51b188c
42b47cb
9e378bb
673c451
18bf2fe
9ae2014
831c233
42f19f3
c03bbee
0762798
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this too much detail maybe? (Also: Would we want to avoid "vscode" and use "devcontainer" instead?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, upon a re-read, it does feel a bit specific and VS Code-centric (and while these are VS Code docs, this is the section on the open agnostic CLI). We had added it based on previous user request, but I think that may have been a singular or small number of users, so I don't anticipate this would be a big point of confusion. Removed, cc @Chuxel if you have other thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit of doc was actually contributed by a user who apparently hit this, so not sure we want to remove it, but it's more of a "tip" than a requirement - it could be moved to an "Advanced" topic (though maybe linked from here?) Agree that using
devcontainer-cli
as the ARG name is better than vscode tho.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be loosely enough related to https://code.visualstudio.com/remote/advancedcontainers/reduce-docker-warnings, that I could add the info there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just pushed a change to add this info in https://code.visualstudio.com/remote/advancedcontainers/reduce-docker-warnings and to point to it from devcontainer-cli.md. I also updated the ARG name to
devcontainercli
.