Skip to content

Commit

Permalink
Merge pull request #114 from microsoft/lramos15/mute-goose
Browse files Browse the repository at this point in the history
Don't bundle 1DS as it can cause issues with webpack
  • Loading branch information
lramos15 authored Jun 27, 2022
2 parents 5834697 + 19cd0eb commit 04ff08d
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 33 deletions.
8 changes: 4 additions & 4 deletions .esbuild.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ esbuild.build({
entryPoints: ['src/node/telemetryReporter.ts'],
tsconfig: "./src/node/tsconfig.json",
bundle: true,
external: ['vscode'],
external: ['vscode', '@microsoft/1ds-core-js', '@microsoft/1ds-post-js'],
sourcemap: true,
platform: 'node',
target: ['node14'],
Expand All @@ -28,7 +28,7 @@ esbuild.build({
tsconfig: "./src/node/tsconfig.json",
bundle: true,
sourcemap: false,
external: ['vscode'],
external: ['vscode', '@microsoft/1ds-core-js', '@microsoft/1ds-post-js'],
minify: true,
platform: 'node',
target: ['node14'],
Expand All @@ -42,7 +42,7 @@ esbuild.build({
tsconfig: "./src/browser/tsconfig.json",
bundle: true,
sourcemap: true,
external: ['vscode'],
external: ['vscode', '@microsoft/1ds-core-js', '@microsoft/1ds-post-js'],
platform: 'browser',
target: ['es6'],
outfile: 'lib/telemetryReporter.web.js',
Expand All @@ -54,7 +54,7 @@ esbuild.build({
format: "esm",
bundle: true,
sourcemap: false,
external: ['vscode'],
external: ['vscode', '@microsoft/1ds-core-js', '@microsoft/1ds-post-js'],
minify: true,
platform: 'browser',
target: ['es6'],
Expand Down
40 changes: 14 additions & 26 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@vscode/extension-telemetry",
"description": "A module for first party microsoft extensions to report consistent telemetry.",
"version": "0.6.1",
"version": "0.6.2",
"author": {
"name": "Microsoft Corporation"
},
Expand All @@ -17,9 +17,11 @@
"test": "tsc -p 'test/tsconfig.json' && mocha lib/test/*",
"compile": "tsc -noEmit -p 'src/browser/tsconfig.json' && tsc -noEmit -p 'src/node/tsconfig.json' && npm run build"
},
"devDependencies": {
"dependencies": {
"@microsoft/1ds-core-js": "^3.2.3",
"@microsoft/1ds-post-js": "^3.2.3",
"@microsoft/1ds-post-js": "^3.2.3"
},
"devDependencies": {
"@microsoft/applicationinsights-web": "^2.6.4",
"@types/mocha": "^9.1.1",
"@types/node": "^16.11.32",
Expand Down

0 comments on commit 04ff08d

Please sign in to comment.