fix: leverage jdtutils to get project correct#940
Merged
wenytang-ms merged 4 commits intomainfrom Nov 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to consistently use JDTUtils for project and resource resolution, improving reliability and performance when obtaining project paths and compilation units. The changes address issues where project information and import data could not be retrieved properly.
- Replaced manual URI parsing and resource lookup with JDTUtils methods
- Unified cache key format to use URIs instead of file paths
- Removed custom
findProjectByPathmethod in favor of JDTUtils.findResource
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ProjectResolver.java | Replaced ResourceUtils with JDTUtils for project resolution; updated cache keys to use URIs instead of file paths; removed custom project lookup method |
| ContextResolver.java | Changed resource accessibility checks to use JDTUtils.toUri; added support for getting URIs from class files (binary types) |
| ProjectCommand.java | Simplified compilation unit resolution by using JDTUtils.resolveCompilationUnit directly instead of manual file resource lookup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/ProjectCommand.java
Outdated
Show resolved
Hide resolved
testforstephen
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve such issue according to data