Fix Edit Data Column Header Focus Outline#22274
Merged
lewis-sanchez merged 1 commit intoJun 2, 2026
Merged
Conversation
lewis-sanchez
requested review from
Benjin,
aasimkhan30,
allancascante,
caohai,
kburtram,
laurenastrid1 and
ssreerama
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Fluent SlickGrid webview styling to align the grid’s focus outline color (notably in Edit Data column headers during keyboard navigation) with VS Code’s focusBorder theme token.
Changes:
- Add a Fluent SlickGrid CSS variable mapping
--slick-focus-outline-colorto--vscode-focusBorderto ensure the focus indicator uses the correct theme color.
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22274 +/- ##
=======================================
Coverage 74.38% 74.38%
=======================================
Files 408 408
Lines 128372 128372
Branches 7779 7779
=======================================
Hits 95486 95486
Misses 32886 32886
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
caohai
approved these changes
Jun 2, 2026
lewis-sanchez
deleted the
lewissanchez/editData/fix-column-header-highlighting
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the focus border color that appears in the Edit Data column headers with keyboard navigation.
Before:
After:
Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines