Skip to content

LEGO: Pull request from lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260603153914707 to main#22279

Merged
Benjin merged 1 commit into
mainfrom
lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260603153914707
Jun 3, 2026
Merged

LEGO: Pull request from lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260603153914707 to main#22279
Benjin merged 1 commit into
mainfrom
lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260603153914707

Conversation

@csigs
Copy link
Copy Markdown
Member

@csigs csigs commented Jun 3, 2026

LEGO: Pull request from lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260603153914707 to main with localized lcls

@csigs csigs requested a review from kburtram as a code owner June 3, 2026 15:39
Copilot AI review requested due to automatic review settings June 3, 2026 15:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates auto-generated localization .xlf.lcl files to reflect new/updated English source strings (notably adding {0} placeholders) and adds translations for new settings/help text across multiple locales.

Changes:

  • Add localized strings for “Failed to save results. {0}”, “Started saving results to {0}”, and “Successfully saved results to {0}”.
  • Remove older variants of those strings that lacked the {0} placeholder.
  • Add localized descriptions for new configuration strings (e.g., message timestamps in “Copy All” and showing a copy notification).

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
localization/LCL/zh-Hant/vscode-mssql.xlf.lcl Updates Traditional Chinese (Taiwan) localized entries for new/updated strings and settings descriptions.
localization/LCL/zh-Hans/vscode-mssql.xlf.lcl Updates Simplified Chinese localized entries for new/updated strings and settings descriptions.
localization/LCL/ru/vscode-mssql.xlf.lcl Updates Russian localized entries for new/updated strings and settings descriptions.
localization/LCL/pt-BR/vscode-mssql.xlf.lcl Updates Brazilian Portuguese localized entries for new/updated strings and settings descriptions.
localization/LCL/ko/vscode-mssql.xlf.lcl Updates Korean localized entries for new/updated strings and settings descriptions.
localization/LCL/ja/vscode-mssql.xlf.lcl Updates Japanese localized entries for new/updated strings and settings descriptions.
localization/LCL/it/vscode-mssql.xlf.lcl Updates Italian localized entries for new/updated strings and settings descriptions.
localization/LCL/fr/vscode-mssql.xlf.lcl Updates French localized entries for new/updated strings and settings descriptions.
localization/LCL/es/vscode-mssql.xlf.lcl Updates Spanish localized entries for new/updated strings and settings descriptions.
localization/LCL/de/vscode-mssql.xlf.lcl Updates German localized entries for new/updated strings and settings descriptions.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 78798 KB 78798 KB ⚪ 0 KB ( 0% )
sql-database-projects VSIX 6309 KB 6309 KB ⚪ 0 KB ( 0% )
data-workspace VSIX 535 KB 535 KB ⚪ 0 KB ( 0% )
keymap VSIX 7 KB 7 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.29%. Comparing base (6c82bda) to head (02a1e2c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #22279      +/-   ##
==========================================
- Coverage   74.34%   74.29%   -0.06%     
==========================================
  Files         407      407              
  Lines      128228   128228              
  Branches     7766     7759       -7     
==========================================
- Hits        95335    95269      -66     
- Misses      32893    32959      +66     
Flag Coverage Δ
data-workspace 77.10% <ø> (ø)
mssql 73.97% <ø> (ø)
sqlproj 77.00% <ø> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Benjin Benjin merged commit 877978b into main Jun 3, 2026
2 of 4 checks passed
@Benjin Benjin deleted the lego/hb_8a5c857d-921a-4789-a5f2-d04520db775e_20260603153914707 branch June 3, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants