Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable glibc sysroot setup when building with emcc #27

Merged
merged 2 commits into from
May 6, 2024

Conversation

deepak1556
Copy link
Contributor

Emscripten provides it own version of libc and libc++ libraries via sysroot option, avoid using our sysroot in this case.

Sanity build : https://dev.azure.com/monacotools/Monaco/_build/results?buildId=271902&view=results

@deepak1556 deepak1556 added this to the May 2024 milestone May 6, 2024
@deepak1556 deepak1556 self-assigned this May 6, 2024
@deepak1556 deepak1556 marked this pull request as ready for review May 6, 2024 10:44
@deepak1556 deepak1556 enabled auto-merge (squash) May 6, 2024 10:45
@deepak1556 deepak1556 requested a review from alexdima May 6, 2024 10:45
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@deepak1556 deepak1556 merged commit fa3c611 into main May 6, 2024
8 checks passed
@deepak1556 deepak1556 deleted the robo/fix_ci branch May 6, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants