lint issues

microsoft · Apr 4, 2024 · 5f73272 · 5f73272
1 parent 0d0a3d1
commit 5f73272
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/extensions/github-authentication/src/common/env.ts b/extensions/github-authentication/src/common/env.ts
@@ -29,7 +29,7 @@ export function isSupportedClient(uri: Uri): boolean {
 
 export function isSupportedTarget(type: AuthProviderType, enterpriseSettings?: EnterpriseSettings): boolean {
 	return (
-		type === AuthProviderType.github || enterpriseSettings?.ssoId != undefined ||
+		type === AuthProviderType.github || enterpriseSettings?.ssoId !== undefined ||
 		isHostedGitHubEnterprise(enterpriseSettings?.uri!)
 	);
 }

diff --git a/extensions/github-authentication/src/flows.ts b/extensions/github-authentication/src/flows.ts
@@ -170,7 +170,7 @@ const allFlows: IFlow[] = [
 				cancellable: true
 			}, async (_, token) => {
 				const promise = uriHandler.waitForCode(logger, scopes, nonce, token);
-				let loginAuthorizeSearchParams = new URLSearchParams([
+				const loginAuthorizeSearchParams = new URLSearchParams([
 					['client_id', Config.gitHubClientId],
 					['redirect_uri', redirectUri.toString(true)],
 					['scope', scopes],
@@ -179,13 +179,13 @@ const allFlows: IFlow[] = [
 				if (existingLogin) {
 					loginAuthorizeSearchParams.append('login', existingLogin);
 				}
-				let loginAuthorizeUri = baseUri.with({
+				const loginAuthorizeUri = baseUri.with({
 					path: '/login/oauth/authorize',
 					query: loginAuthorizeSearchParams.toString()
 				});
 				let uri = loginAuthorizeUri;
 
-				if (enterpriseSettings?.ssoId != undefined) {
+				if (enterpriseSettings?.ssoId !== undefined) {
 					const searchParams = new URLSearchParams([
 						['return_to', encodeURIComponent(loginAuthorizeUri.toString(true))],
 					]);
@@ -340,14 +340,14 @@ const allFlows: IFlow[] = [
 
 			await env.clipboard.writeText(json.user_code);
 
-			let verificationUri = json.verification_uri
-			if (enterpriseSettings?.ssoId != undefined) {
+			let verificationUri = json.verification_uri;
+			if (enterpriseSettings?.ssoId !== undefined) {
 				verificationUri = baseUri.with({
 					path: `/enterprises/${enterpriseSettings.ssoId}/sso`,
 					query: new URLSearchParams([
 						['return_to', encodeURIComponent(verificationUri)],
 					]).toString(),
-				}).toString(true)
+				}).toString(true);
 			}
 
 			const uriToOpen = await env.asExternalUri(Uri.parse(verificationUri));