Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing large outline Maximum call stack size exceeded #235889

Closed
RedCMD opened this issue Dec 12, 2024 · 4 comments · May be fixed by #235893
Closed

Closing large outline Maximum call stack size exceeded #235889

RedCMD opened this issue Dec 12, 2024 · 4 comments · May be fixed by #235893
Assignees
@joaomoreno @benibenj
Labels
bug Issue identified by VS Code Team member as probable bug perf tree-widget Tree widget issues verified Verification succeeded
Milestone
January 2025

Comments

@RedCMD
Copy link
Contributor

RedCMD commented Dec 12, 2024

Closing a file with a very large outline open causes a Max Call Stack Error

Steps to Reproduce:

  1. change json.maxItemsComputed to 50000000
"json.maxItemsComputed": 50000000
  1. open file 200k comments lag.json
  2. open outline
  3. close file
  4. notice max call stack errorImage

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.96.0
  • OS Version: Windows 11
faraon-bot added a commit to faraon-bot/vscode that referenced this issue Dec 12, 2024
@faraon-bot
Fix max call stack error when closing large outline
ed20c11 
Fixes microsoft#235889

Implement an iterative approach to manage the outline in the `OutlineModel` class.

* Add a stack to handle the children of the outline elements iteratively in the `_makeOutlineElement` method.
* Replace the recursive call with a loop that processes the stack in the `_makeOutlineElement` method.
* Add a stack to handle the children of the document symbols iteratively in the `_flattenDocumentSymbols` method.
* Replace the recursive call with a loop that processes the stack in the `_flattenDocumentSymbols` method.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/vscode/issues/235889?shareId=XXXX-XXXX-XXXX-XXXX).
@faraon-bot faraon-bot mentioned this issue Dec 12, 2024
Open
@jrieken jrieken added outline Source outline view issues tree-widget Tree widget issues bug Issue identified by VS Code Team member as probable bug and removed outline Source outline view issues new release labels Dec 12, 2024
jrieken added a commit that referenced this issue Dec 12, 2024
@jrieken
don't spread huge arrays, use insertInto to avoid runtime failure
f647ff4 
#235889
@jrieken jrieken mentioned this issue Dec 12, 2024
Merged
@jrieken jrieken assigned benibenj and unassigned jrieken Dec 12, 2024
@benibenj benibenj added this to the January 2025 milestone Dec 12, 2024
@jrieken
Copy link
Member

jrieken commented Dec 12, 2024

@benibenj #235926 fixes the call size error (basically ...hugeArray ruins the stack) but there is more to it.

Once the doesn't fail anymore, you'll notice that getViewState is very slow, freezing the renderer 1.5sec. So, I'd suggest to keep this issue to fix the perf (maybe add an upper bound)

Image

@benibenj benibenj added the perf label Dec 12, 2024
jrieken added a commit that referenced this issue Dec 12, 2024
@jrieken
don't spread huge arrays, use insertInto to avoid runtime failure (#2…
d590c74 
…35926)

#235889
@RedCMD
Copy link
Contributor Author

RedCMD commented Dec 12, 2024 •
edited
Loading

how come the tree is being updated?
shouldn't it be getting destroyed

@benibenj
Copy link
Contributor

I assume the performance problem was solved with #236601
I would be great if you could verify this by using our newest insiders build https://code.visualstudio.com/insiders/ and let us know if the changes fix the problem. Thanks

@benibenj benibenj added the author-verification-requested Issues potentially verifiable by issue author label Dec 20, 2024
@RedCMD
Copy link
Contributor Author

RedCMD commented Dec 20, 2024

/verified

@vs-code-engineering vs-code-engineering bot added verified Verification succeeded and removed author-verification-requested Issues potentially verifiable by issue author labels Dec 20, 2024
faraon-bot added a commit to faraon-bot/vscode that referenced this issue Dec 31, 2024
@faraon-bot
Fix max call stack error when closing large outline
d9b06e8 
Related to microsoft#235889

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/vscode/issues/235889?shareId=XXXX-XXXX-XXXX-XXXX).
@faraon-bot faraon-bot mentioned this issue Dec 31, 2024
Open
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@benibenj benibenj

Labels
bug Issue identified by VS Code Team member as probable bug perf tree-widget Tree widget issues verified Verification succeeded
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

Fix max call stack error when closing large outline faraon-bot/vscode
4 participants
@joaomoreno @jrieken @RedCMD @benibenj