-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix max call stack error when closing large outline #235893
base: main
Are you sure you want to change the base?
Conversation
Fixes microsoft#235889 Implement an iterative approach to manage the outline in the `OutlineModel` class. * Add a stack to handle the children of the outline elements iteratively in the `_makeOutlineElement` method. * Replace the recursive call with a loop that processes the stack in the `_makeOutlineElement` method. * Add a stack to handle the children of the document symbols iteratively in the `_flattenDocumentSymbols` method. * Replace the recursive call with a loop that processes the stack in the `_flattenDocumentSymbols` method. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/vscode/issues/235889?shareId=XXXX-XXXX-XXXX-XXXX).
@faraon-bot please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
The changes in the PR seems unrelated to the linked issue and the error that's reported there. |
Fixes #235889
Implement an iterative approach to manage the outline in the
OutlineModel
class._makeOutlineElement
method._makeOutlineElement
method._flattenDocumentSymbols
method._flattenDocumentSymbols
method.For more details, open the Copilot Workspace session.