Add support for * in workspace symbol search #159377
Conversation
gayanper
force-pushed
the
wildcard_fuzzy
branch
from
ff15516 to
c8f220f
Compare
gayanper
changed the title
|
@TylerLeonhardt or @jrieken will you be able to have a look at this change and let me know what you think ? |
gayanper
force-pushed
the
wildcard_fuzzy
branch
3 times, most recently
from
afbdf25 to
978a067
Compare
|
@jrieken will you have time to check this change? |
|
No, I am the wrong person for this |
@jrieken could help me to reach the correct leads in this area to get an review ? |
|
I think we can improve this change not to be intrusive on fuzzy score login, will see if the problem could be solved without replacing * and ? and try to solve it at the symbol picker side instead. |
gayanper
force-pushed
the
wildcard_fuzzy
branch
from
978a067 to
4ab6995
Compare
gayanper
changed the title
|
@TylerLeonhardt I have update the PR with a new approach to solve the * issue. Please let me know what you think. |
|
Any feedback on this PR ? |
|
Hey 👋 I haven't had the time to look at this PR. I'll try to get to it in November (I'll be going out of town for 2 weeks) |
Just a ping to see if this PR is in the todo list for November release |
|
Any update on this ? |
|
-- please? |
|
@TylerLeonhardt any updates on this ? Will this be considered for next release in 2023 ? |
|
Any update on this ? |
The fix change the code so that the query to LS is sent with * while the query components used to perform the matching is fixed by removing the * characters for workspace symbol search.
gayanper
force-pushed
the
wildcard_fuzzy
branch
from
c8844a2 to
602f161
Compare
|
Is this still relevant? |
|
Yes, this continues to be relevant because without it makes search for symbols quite hard |
The new changset fix the issue with * in workspace symbol search by passing the original query with * in the LS, but use query components without * for matching with fuzzy score.
Improvement to resolve : #149144