Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #194906 #197380

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

fixes #194906 #197380

wants to merge 12 commits into from

Conversation

nikhilkarve
Copy link

@nikhilkarve nikhilkarve commented Nov 3, 2023 •
edited by TylerLeonhardt
Loading

Fixes #194573

@nikhilkarve nikhilkarve mentioned this pull request Nov 3, 2023
Closed
TylerLeonhardt
TylerLeonhardt reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Just a few more comments

@TylerLeonhardt TylerLeonhardt self-assigned this Nov 3, 2023
@nikhilkarve
Copy link
Author

nikhilkarve commented Nov 4, 2023 •
edited
Loading

Hey @TylerLeonhardt @andreamah , let me know if there are any more changes needed. I have added comments! Have a great weekend!:)

@nikhilkarve
Copy link
Author

Hey @TylerLeonhardt @andreamah , let me know if there are any more changes needed. I have added comments! Have a great weekend!:)

Hey team! @andreamah @TylerLeonhardt
I know you must be busy, but just checking in to see if there is anything I can do from my side!

@nikhilkarve nikhilkarve reopened this Nov 16, 2023
@TylerLeonhardt TylerLeonhardt added this to the December 2023 milestone Nov 27, 2023
@nikhilkarve
Copy link
Author

Hi @andreamah @TylerLeonhardt , any update on this? Is there any issue which needs to be resolved before this gets in? If there is, I can take a look at that too. Or if any refactoring is needed for this PR, I can do that too. Let me know if there is anything I can do to help!

andreamah
andreamah previously approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also tried it out and it seems to work as intended. 👍

@nikhilkarve
Copy link
Author

Looks good! Also tried it out and it seems to work as intended. 👍

Thank you so much @andreamah !

@nikhilkarve
Copy link
Author

Hi @andreamah @TylerLeonhardt , there was a merge conflict, so I updated the branch. Is there anything remaining?

@TylerLeonhardt TylerLeonhardt modified the milestones: December / January 2024, February 2024 Jan 23, 2024
@vivodi
Copy link

vivodi commented Dec 29, 2024

Is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreamah andreamah andreamah left review comments

@TylerLeonhardt TylerLeonhardt Awaiting requested review from TylerLeonhardt

At least 1 approving review is required to merge this pull request.

Assignees

@TylerLeonhardt TylerLeonhardt

Labels
None yet
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Search Files By Name Should Use Highlighted Text
4 participants
@nikhilkarve @vivodi @TylerLeonhardt @andreamah