-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add nlsConfig to webWorker #192808 #199258
Open
yiliang114
wants to merge
18
commits into
microsoft:main
Choose a base branch
from
yiliang114:prickly-earthworm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1f40cff
fix: add nlsConfig to webWorker #192808
yiliang114 25de25f
fix: add nlsConfig to webWorker #192808
yiliang114 01f5819
Merge remote-tracking branch 'origin/main' into prickly-earthworm
yiliang114 8faf47c
Merge branch 'main' into prickly-earthworm
yiliang114 0167ea5
Merge branch 'main' into prickly-earthworm
yiliang114 ee0f46f
Merge remote-tracking branch 'origin/main' into prickly-earthworm
yiliang114 58dabe3
fix: use `platform.language` replace get value from localStorage or n…
yiliang114 a88dc1a
Merge remote-tracking branch 'yiliang114/prickly-earthworm' into pric…
yiliang114 7b5f677
Use platform.LANGUAGE_DEFAULT to replace 'en'
yiliang114 c91d6fa
Merge remote-tracking branch 'origin/main' into prickly-earthworm
yiliang114 415cbe0
Fix #192808
yiliang114 5b99eba
Merge branch 'main' into prickly-earthworm
yiliang114 ad14cc9
Merge branch 'main' into prickly-earthworm
yiliang114 28b02c2
Merge branch 'main' into prickly-earthworm
yiliang114 e7c58a3
Merge branch 'main' into prickly-earthworm
yiliang114 0048b55
Merge branch 'main' into prickly-earthworm
yiliang114 4f221a3
Merge branch 'main' into prickly-earthworm
yiliang114 ab58c3a
Merge branch 'main' into prickly-earthworm
yiliang114 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ | |
const name = searchParams.get('debugged') ? 'DebugWorkerExtensionHost' : 'WorkerExtensionHost'; | ||
const parentOrigin = searchParams.get('parentOrigin') || window.origin; | ||
const salt = searchParams.get('salt'); | ||
const locale = searchParams.get('locale'); | ||
|
||
(async function () { | ||
const hostnameValidationMarker = 'v--'; | ||
|
@@ -73,6 +74,10 @@ | |
} | ||
|
||
const worker = new Worker(workerUrl, { name }); | ||
if (locale) { | ||
// send before `vs/workbench/api/worker/extensionHostWorker`load event. | ||
worker.postMessage(`worker:init-locale:${locale}`); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because the worker cannot read the localstorge directly and the iframe may not be in the same domain name as the main application, the method used is to obtain the language in the host, pass it to the iframe, and then pass it to the worker. I don't know if this will be strange |
||
} | ||
worker.postMessage('vs/workbench/api/worker/extensionHostWorker'); | ||
const nestedWorkers = new Map(); | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like you could just do this:
and get rid of the other changes in this file.