Open File... selection is first file rather than last / In quick input move active item to the very first item in the list rather than the very last #202406
Conversation
|
@microsoft-github-policy-service agree |
|
@Yoyokrazy Hi Michael. What is the policy for contributions from people outside of Microsoft? Does it make sense for me to believe that this will be reviewed any time soon or should I assume that the review process will take at least a month? Right now I have two possible paths:
I'm fine with both, though would prefer the first one as you already have a lot of code written here, but if you understand that almost surely this feature will take a very long time to review then please tell me so I start working on the VS Code extension instead without having false expectations |
|
@CrafterKolyan Sorry about the delay, I've gone ahead and assigned a more relevant dev to this and the linked issue. cc @benibenj |
| @@ -1865,7 +1865,7 @@ export class List<T> implements ISpliceable<T>, IDisposable { | |||
| return this.getFocus().map(i => this.view.element(i)); | |||
| } | |||
|
|
|||
| reveal(index: number, relativeTop?: number, paddingTop: number = 0): void { | |||
| reveal(index: number, relativeTop?: number, paddingTop: number = 0, applyRelativeTopOnlyIfNotVisible: boolean = false): void { | |||
There was a problem hiding this comment.
There should not be a change to the list widget. The consumer of the list should be able to adapt the arguments depending on if an item is visible or not.
There was a problem hiding this comment.
Thank you for review. Agree the code now looks much nicer. Fixed.
TylerLeonhardt
requested review from
alexr00 and
TylerLeonhardt
and removed request for
TylerLeonhardt and
alexr00
|
@TylerLeonhardt Hi Tyler, any chance to review it during this week? |
|
Hi @CrafterKolyan, I'm having a hard time understanding the actual change in behavior here. Can you help me understand a bit more? Perhaps 2 gifs that show the same thing with the difference? |
|
Hi @TylerLeonhardt, see the video below On the left you see the way Open File... currently works in VS Code Currently it's harder to discover there's folder |
|
@TylerLeonhardt any updates on the review? I'm not sure if my video helped you to understand the difference. Also I'm not sure if you asked me to do gifs because you need specifically gifs (because e.g. you can't watch video due to too restricting policy of Microsoft or something). |
…ther than to the very last
CrafterKolyan
force-pushed
the
simple-dialog-select-top-instead-of-last
branch
from
1cc507a to
f7f0921
Compare
|
Hi @CrafterKolyan haven't forgotten about this but I'm a bit busy with some other things and a change like this I wanna take time and do some manual tests. The video you supplied is helpful! Thanks! |
|
Is this still relevant? |
This is inspired by #202367. This doesn't fix it completely as no fuzzy search is working, though at least it makes it easier to reveal stuff in all lists inside VS Code as now if the item was not visible it will appear at the top rather than at the very bottom.
See video for the new behaviour:
https://github.com/microsoft/vscode/assets/9883873/eca0a3e3-2e1c-4339-b8da-72d45816e96f