Onboard the QuickPick list to custom checkboxes instead of native ones #208256
+55
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thank you for submitting a Pull Request. Please: * Read our Pull Request guidelines: https://github.com/microsoft/vscode/wiki/How-to-Contribute#pull-requests * Associate an issue with the Pull Request. * Ensure that the code is up-to-date with the `main` branch. * Include a description of the proposed changes and how to test them. --> with one unchecked: <img width="530" alt="image" src="https://github.com/microsoft/vscode/assets/2644648/e2c096f0-407f-4d70-9f27-4366b7772ffa"> with all checked: <img width="521" alt="image" src="https://github.com/microsoft/vscode/assets/2644648/7df04231-397f-4279-8535-7606a951a813"> Fixes #163230
TylerLeonhardt
force-pushed
the
tyler/impressed-lemming
branch
from
a07ea3f to
9e73af4
Compare
|
@TylerLeonhardt is there a reason why on the Quickpick page on the vscode docs, the multi-select seems to use proper vscode styling for a checkbox: While this does not actually exist in vscode? How have they done it? I don't want my quickpick multiselect checkboxes to look bad like this... Also, what does this mean?
|
|
It looks like the first screenshot is from a figma mock up and not the actual product. Can you open an issue on https://github.com/microsoft/vscode-docs and we can get that fixed with an actual product screenshot?
It means these custom checkboxes don't have a visual indicator if they are disabled (if you can't change their state) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with one unchecked:
with all checked:
Fixes #163230
In draft until Checkboxes have disabled style.