Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with incorrect parsing of command line arguments #222971

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

okineadev
Copy link

Fixed bug with incorrect parsing of command line arguments and fixed path to .xlf files
Fixes #201711

I must note that the code is bad and not tested at all!, it's very bad, and the person who made it is lazy.
I ask you to test the code before you push it, so that others do not have to fix the code with their own hands to perform some small task

@okineadev
Copy link
Author

@microsoft-github-policy-service agree

@okineadev
Copy link
Author

image

What do I need to do?

@okineadev
Copy link
Author

@TylerLeonhardt

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Aug 1, 2024

Please follow the Code of Conduct for vscode or I will have to take action. Specifically: Demonstrating empathy and kindness toward other people

We've been neck deep in the latest VS Code release so I've not had time to look at this until now.

The error says that your change to the TS file needs a subsequent change to the JS file. While it looks like you've done this, you can run this to see if anything is missing:

yarn --cwd build run compile

@okineadev
Copy link
Author

Please follow the Code of Conduct for vscode or I will have to take action. Specifically: Demonstrating empathy and kindness toward other people

We've been neck deep in the latest VS Code release so I've not had time to look at this until now.

The error says that your change to the TS file needs a subsequent change to the JS file. While it looks like you've done this, you can run this to see if anything is missing:

yarn --cwd build run compile

Thanks. Done

@okineadev

This comment was marked as outdated.

@okineadev
Copy link
Author

@TylerLeonhardt, Everything is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR in update-localization-extension
2 participants