Click to copy/exec shell code in markdown preview #234981
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
yelirekim
force-pushed
the
markdown-run-shell-code-in-terminal
branch
from
9610923 to
6cee380
Compare
|
Rebased/retested today after the latest release. |
|
@mjbvz can I get some attention here? Anything I can do to make this easier to review? I had thought about separating out just the "copy" part and getting that through review first in order to segment discussion of any security concerns from the UI addition, would that help? |
yelirekim
force-pushed
the
markdown-run-shell-code-in-terminal
branch
from
6cee380 to
3b45308
Compare
|
rebased/retested |
Introduces a `CodeBlockManager` class that wraps every code block with a container and overlays either one or two buttons: - A copy button that copies the code to the clipboard - An execute button that executes the code in the active terminal, or creates a new terminal if none is active The execute button is only shown if the markdown file is in the workspace that the preview is running in, and if the user trusts that workspace. Minimal changes to dependencies and `esbuild-preview.js` were introduced to support Codicons in the preview web view.
yelirekim
force-pushed
the
markdown-run-shell-code-in-terminal
branch
from
3b45308 to
9855e95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested in #209876
Introduces a
CodeBlockManagerclass that wraps every code block with a container and overlays either one or two buttons:The execute button is only shown if the markdown file is in the workspace that the preview is running in, and if
workspace.isTrusted.Minimal changes to dependencies and
esbuild-preview.jswere introduced to support Codicons in the preview web view.Testing:
Made a markdown file with a few code blocks of various sizes and an image. Opened this markdown file from within both trusted and untrusted workspaces. Ensured that all of the following worked as expected in both cases:
30 Second Loom Demo: