-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove legacy server support #235232
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Behavior moving forward
|
Thank you for your work on this. I appreciate your efforts to get this out early enough that we can build confidence in whatever workarounds we may choose to use. |
This Insiders build can't connect to any host, all with the same env as VSCode: 1.96.0-insiderVersion: 1.96.0-insider (Universal) Commit: 785c2b4 Date: 2024-12-04T09:42:59.065Z Electron: 32.2.6 ElectronBuildId: 10629634 Chromium: 128.0.6613.186 Node.js: 20.18.1 V8: 12.8.374.38-electron.0 OS: Darwin arm64 24.1.0
1.95.3 (Universal)Version: 1.95.3 (Universal) Commit: f1a4fb1 Date: 2024-11-13T14:50:04.152Z Electron: 32.2.1 ElectronBuildId: 10427718 Chromium: 128.0.6613.186 Node.js: 20.18.0 V8: 12.8.374.38-electron.0 OS: Darwin arm64 24.1.0there is no output, it just connects:
|
f9ac576
to
33f45d6
Compare
We are exploring an option for Remote SSH that allows providing a custom glibc path to the vscode server which could serve as a temporary workaround, this mode will be tagged as unsupported but provides a way to not disable vscode updates until your system can be transitioned. The flow would be as follows,
Here is a quick demo of the above, @murkvin and others please provide feedback if this helps your case. I will provide links to the builds once they are ready later today. Screen.Recording.2025-01-16.at.23.29.01.mov |
d205d43
to
0b72af9
Compare
9da9d68
to
05e3e50
Compare
Hi @deepak1556, I'm checking in here on the status of available samples. If they are available, could you provide sample builds for VS Code + Remote - SSH? |
Excellent! Thank you for the follow-up. I really appreciate your collaboration here. At this stage, things seem to be working! I improvised a bit on the instructions (especially around creating the sysroots). Based on your comment, it sounds like you're still working on some of that, so I won't jump ahead there. One note that I do want to share is that folks should check their |
I have updated the docs yesterday https://github.com/microsoft/vscode-docs/pull/7953/files, can you check again and if there is something to be added please share.
Good point to add in the docs, I have been testing with 0.18. There is one issue I am aware of NixOS/patchelf#524 the order of the calls matter otherwise it can lead to corrupted binaries. |
05e3e50
to
ea65039
Compare
An you please add to the docs an approximation of how much MB will be downloaded and how long this takes to built? And... as the workaround is available that way - is there a reason to not distribute a "ready to use" sysroot which could be downloaded and semi-automated for remote-development? |
Hello @deepak1556 , I tried to download the win32-x64-archive at https://vscode.download.prss.microsoft.com/dbazure/download/insider/05e3e508d2c3a9761665d661e5c4e1e73ee54ad0/VSCode-win32-x64-1.97.0-insider.zip but I am experiencing a gateway error :
Can you help me ? I need the archive one to test in "portable" mode and to not alter my current vscode installation. Thanks Ghislain |
@GhislainC I can confirm the error, seems like the win32 archive failed to publish. Let me retrigger build off a new commit, will post here again once the bits are published. |
ea65039
to
be8b8da
Compare
Not sure if I understood this correctly, but the sysroot will not be downloaded by the remote server it has to be predeployed on the remotes and the env variables configured were you expect the server to connect.
We are dropping support for legacy servers due to maintenance reasons, maintaining the sysroot will be no different. The workaround exists to ease transition of systems that can build and deploy the sysroots without having to disable VSCode updates. |
@GhislainC you can try https://unix.stackexchange.com/questions/4921/sh-startup-files-over-ssh/ or remote commands with |
Ok thanks. It works now for remote SSH (I have to tune a little bit the provided crosstool-ng's config). I tested the sysroot with both RemoteSSH (RHEL7) and Dev Containers (centos7), it works! Thanks for your solution allowing us to continue to work. Thank you also @deepak1556 for your quick and efficient assistance on this thread. Ghislain |
Hi @deepak1556 the kernel info: 4.4.0-31-generic thanks |
Hi @liximin I faced exactly the same problem with RedHat 7 |
@GhislainC thank you , it works now. |
I tried this out and it worked. Thanks for providing a workaround for those of us stuck on old OS's! Minor thing - the correct patchelf variable to set is |
Fixes #231623
DO NOT MERGE until March 2025