Introducing inner scope sticky scroll #235949
Draft
+47
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MAZ01001
reviewed
Feb 6, 2025
| @@ -558,11 +558,16 @@ export class StickyScrollController extends Disposable implements IEditorContrib | |||
| if (arrayVisibleRanges.length !== 0) { | |||
| const fullVisibleRange = new StickyRange(arrayVisibleRanges[0].startLineNumber, arrayVisibleRanges[arrayVisibleRanges.length - 1].endLineNumber); | |||
| const candidateRanges = this._stickyLineCandidateProvider.getCandidateStickyLinesIntersecting(fullVisibleRange); | |||
| for (const range of candidateRanges) { | |||
| const reverse = true; | |||
| const finalCandidateRanges = reverse ? candidateRanges.reverse() : candidateRanges; | |||
There was a problem hiding this comment.
Wouldn't this (line 562 of changes) be better to write it like this:
if (reverse) candidateRanges.reverse();
// and rename all following `finalCandidateRanges` to `candidateRanges`Since Array.reverse modifies the list in place, and thus finalCandidateRanges will equal candidateRanges either way (same reference).
Or if a copy is desired, not to modify candidateRanges, maybe something like this:
const finalCandidateRanges = reverse ? Array.from(candidateRanges, (_, i) => candidateRanges[candidateRanges.length - 1 - i]) : candidateRanges;But I don't know for sure since I'm not familiar with the codebase...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #208406