Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include commands from default keybindings in _getAllCommands #238163

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Include commands from default keybindings in _getAllCommands #238163

merged 1 commit into from
Jan 17, 2025

Conversation

bhavyaus
Copy link
Collaborator

No description provided.

@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Jan 17, 2025
@bhavyaus bhavyaus enabled auto-merge (squash) January 17, 2025 19:59
Tyriar
Tyriar reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is _getAllCommands used elsewhere? This feels risky as someone who hasn't touched this.

@bhavyaus bhavyaus merged commit 2a5b54b into main Jan 17, 2025
8 checks passed
@bhavyaus bhavyaus deleted the dev/bhavyau/keybindings branch January 17, 2025 21:22
@justschen
Copy link
Contributor

@bhavyaus just saw Daniel's comment - maybe followup if needed 😨

@bhavyaus
Copy link
Collaborator Author

Following up with Daniel offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar left review comments

@justschen justschen justschen approved these changes

Assignees

@bhavyaus bhavyaus

Labels
None yet
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.
3 participants
@bhavyaus @justschen @Tyriar