-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve shell env API performance issue for single env approach #238488
Open
anthonykim1
wants to merge
23
commits into
main
Choose a base branch
from
anthonykim1/improveEnvPerf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+197
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/user-attachments/assets/57167cc9-fd5b-424b-b302-83542592365d |
anthonykim1
commented
Jan 23, 2025
src/vs/workbench/contrib/terminal/common/scripts/shellIntegration-bash.sh
Show resolved
Hide resolved
anthonykim1
commented
Jan 23, 2025
src/vs/workbench/contrib/terminal/common/scripts/shellIntegration-bash.sh
Show resolved
Hide resolved
anthonykim1
commented
Jan 23, 2025
src/vs/workbench/contrib/terminal/common/scripts/shellIntegration-bash.sh
Outdated
Show resolved
Hide resolved
anthonykim1
commented
Jan 24, 2025
src/vs/workbench/contrib/terminal/common/scripts/shellIntegration-bash.sh
Outdated
Show resolved
Hide resolved
Dlbandy04
approved these changes
Jan 26, 2025
818Nawaf
approved these changes
Jan 27, 2025
62 tasks
TODO: Should address #238338 (comment) if we were to enable shell env for bash again since it is critical. |
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential root of the performance cause:
Edit: d3ef701 brought back instant bash prompts. I think it was combination of printenv with compgen and tons of printf statements really slowing things down. So Mainly
Scenario number 3 was correct