Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] Attempt to install extensions in workbench that fail to install from remote code-server #238815

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Jan 27, 2025

related: microsoft/vscode-remote-release#9994 , microsoft/vscode-remote-release#5927 (comment) , microsoft/vscode-remote-release#9090 , microsoft/vscode-remote-release#9454 (comment)

Provides a way for the remote server to report back extensions that it could not install. The workbench can read this value and attempt to install these of extensions.

This is useful in cases when a remote does not have access to the marketplace, but a local machine does. This will effectively proxy the installation of an extension through the user's machine, closing several Remote - SSH issues

See early demo below showing the end-to-end. This demo uses a modded Remote - SSH that will connect to a server pre-started on my local machine. That server process is blocked from accessing marketplace.visualstudio.com, causing an error to be thrown in the server

The workbench can reach the marketplace and is able to perform the installation.

b73d660:

Screen.Recording.2025-01-26.at.7.11.48.PM.mov

Provides a way for the remote server to report back to the workbench a
set of extensions that it could not install.  The workbench will
then attempt to install the set of extensions.

This is useful in cases when a remote does not have access to the
marketplace, but a local machine does.  This will effectively proxy
the installation of an extension through the user's machine.
@sandy081
Copy link
Member

@joshspicer Thanks for the initiation. Instead of adding a new failed property, I would use the existing whenExtensionsReady method. Please change it to return all extension IDs or URIs that server should be initialised with. Eg:

whenExtensionsReady(): Promise<Array<string|URI>>

On the workbench, add a new contribution similar to

export class RemoteExtensionsInitializerContribution implements IWorkbenchContribution {
that installs extensions which are missing on the remote.

@joshspicer joshspicer changed the title [draft] Add failed() to IRemoteExtensionsScannerService [draft] Attempt to install extensions in workbench that cannot be installed from remote code-server Jan 27, 2025
@joshspicer joshspicer changed the title [draft] Attempt to install extensions in workbench that cannot be installed from remote code-server [draft] Attempt to install extensions in workbench that fail to install from remote code-server Jan 27, 2025
@sandy081 sandy081 added this to the February 2025 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants