Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Screencast Mode - keyboard overlay timeout #238860

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

newminkyung
Copy link

2025-01-28.12.48.54.mov

Overview

This PR resolves an issue where changes to the screencastMode.keyboardOverlayTimeout setting were not being immediately reflected in the Screencast Mode keyboard overlay.

Key Changes

  • Updated the clearKeyboardScheduler.schedule() method to accept the keyboardMarkerTimeout value dynamically.
    • Previously, the timeout value was fixed when the RunOnceScheduler was initialized.
    • With this change, the updated timeout value is immediately applied without requiring a scheduler restart.

Expected Outcome

  • The keyboard overlay timeout in Screencast Mode now updates in real-time when the screencastMode.keyboardOverlayTimeout setting is modified.
  • Users will experience immediate changes to the overlay duration without any additional steps.

Testing

  • Verified that updating the screencastMode.keyboardOverlayTimeout value in settings.json dynamically adjusts the keyboard overlay timeout in Screencast Mode.
  • Confirmed that the overlay disappears after the specified duration for various timeout values (e.g., 500ms, 5000ms).

@newminkyung newminkyung force-pushed the fix/screencast-timeout branch from 5e5e059 to 5bffda2 Compare January 27, 2025 16:08
Copy link
Contributor

@ohah ohah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screencast mode: keyboard overlay timeout does not respect the value
4 participants