Auto-generated baselines by 1ES Pipeline Templates #238927
Open
+156
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![microsoft-github-policy-service[bot]](https://avatars.githubusercontent.com/in/95686?s=60&v=4){kind=small}
|
Adding @rzhao271 as well |
rzhao271
previously approved these changes
Jan 28, 2025
There was a problem hiding this comment.
LGTM. These BinSkim results are all on the setup files, though, so I wonder whether fixing them requires modifications to innosetup itself. CC @joaomoreno @deepak1556
microsoft-github-policy-service
bot
dismissed
rzhao271’s stale review
via
8180892
|
What are type of errors are found in the setup file ? we don't own the innosetup binaries, we rely on https://github.com/felicienfrancois/node-innosetup-compiler to use the prebuilt ones and I see the package is a bit outdated. The source of truth is at https://github.com/jrsoftware/issrc, we could build from source and apply any required binskim patches (similar to other prebuilt projects we maintain) |
This comment was marked as spam.
This comment was marked as spam.
818Nawaf
approved these changes
Jan 30, 2025
818Nawaf
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.