Skip to content

Conversation

@dmitrivMS
Copy link
Contributor

Fixes #125293

In addition to original scenario in the bug (error/duplicate opened documents) there were more issues down the line:

  • Create untitled doc, enter some text
  • Reopen in Hex Editor -> original bug
  • Save from Hex Editor -> the untitled document was left around and a "save unsaved changes" dialog was popping up -> fixed
  • Now create a new untitled document, enter some text
  • Reopen the new doc in Hex Editor -> we were crashing

With these changes all the above issues are fixed and work as expected.

Moving to Jan milestone since it's a larger change.

Copilot AI review requested due to automatic review settings January 7, 2026 09:26
@dmitrivMS dmitrivMS added the custom-editors Custom editor API (webview based editors) label Jan 7, 2026
@dmitrivMS dmitrivMS requested a review from lramos15 January 7, 2026 09:26
@dmitrivMS dmitrivMS self-assigned this Jan 7, 2026
@vs-code-engineering
Copy link

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/services/untitled/common/untitledTextEditorModel.ts

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

bpasero
bpasero previously requested changes Jan 7, 2026
@bpasero bpasero dismissed their stale review January 7, 2026 11:10

Solved

@dmitrivMS dmitrivMS merged commit 10a5645 into main Jan 8, 2026
22 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/custom-editors-bugs branch January 8, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

custom-editors Custom editor API (webview based editors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom editor reopened from untitled does not properly wire in dirty state?

4 participants