Chat - expand working set when opening a session #286344
Open
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to automatically expand the working set when opening a chat session in the Chat View Pane. When a user loads a chat session, the working set (which contains file attachments and editing context) will now be shown in an expanded state by default, improving visibility of the session's context.
Key Changes
- Added
setWorkingSetCollapsed()method toChatInputPartto programmatically control the working set's collapsed state - Modified
loadSession()inChatViewPaneto expand the working set after successfully loading a session
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Added public method setWorkingSetCollapsed() to allow external control of the working set's collapsed state |
| src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/chatViewPane.ts | Modified loadSession() to expand the working set by calling setWorkingSetCollapsed(false) after successfully loading a chat model |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the holiday we were talking about the fact that most of the time one opens an agent session to look at the changes in the working set. Since the working set is collapsed by default, I added a method to expand the working set only when we open a session. Please let me know if there is a better way to do this.
//cc @bpasero