Skip to content

Conversation

@dmitrivMS
Copy link
Contributor

Fixes #283248

Copilot AI review requested due to automatic review settings January 7, 2026 14:41
@dmitrivMS dmitrivMS added the fetch-tool Issues concerning the fetch internal tool and web extracting service label Jan 7, 2026
@dmitrivMS dmitrivMS self-assigned this Jan 7, 2026
@dmitrivMS dmitrivMS added this to the January 2026 milestone Jan 7, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the web page loader to correctly extract content from nested iframes, addressing issue #283248 where JavaDoc content embedded in iframes was not being retrieved. The fix enables the Page domain, retrieves the complete frame tree, and extracts accessibility content from all frames (main frame and all nested iframes) rather than just the main frame.

Key Changes:

  • Enhanced accessibility tree extraction to iterate through all frames using Chrome DevTools Protocol's Page.getFrameTree command
  • Refactored the accessibility domain to handle multiple root nodes (one per frame) instead of a single tree
  • Added comprehensive test coverage for nested iframe scenarios

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/vs/platform/webContentExtractor/electron-main/webPageLoader.ts Modified extractAccessibilityTreeContent to enable Page domain, fetch frame tree, flatten it using BFS, and extract accessibility nodes from all frames with proper cancellation token handling
src/vs/platform/webContentExtractor/electron-main/cdpAccessibilityDomain.ts Refactored createNodeTree to createNodeTrees to return multiple root nodes for multi-frame scenarios, updated convertAXTreeToMarkdown to process and combine content from all trees
src/vs/platform/webContentExtractor/test/electron-main/webPageLoader.test.ts Extracted common mock setup into setupDebuggerMock helper function, added comprehensive test for nested iframe content extraction, refactored all existing tests to use the new helper

@dmitrivMS dmitrivMS merged commit fcb46c7 into main Jan 9, 2026
22 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/fetch-tool-frames branch January 9, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fetch-tool Issues concerning the fetch internal tool and web extracting service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fetch tool doesn't grab javadocs content

3 participants