Modern UI: Fix redundant tab action fading in connected editor tabs - #336871
Open
na2co3 (na2co3-ftw) wants to merge 1 commit into
Open
na2co3 (na2co3-ftw) wants to merge 1 commit into
na2co3 (na2co3-ftw) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused CSS correction matches existing reservation behavior and includes suitable regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns Modern UI connected-tab fading with reserved action spacing, preventing unnecessary filename fades.
Changes:
- Excludes connected tabs from action fade masks.
- Removes a redundant connected-tab override.
- Adds regression coverage.
| File | Description |
|---|---|
modernUI.contribution.test.ts |
Tests connected-tab fade behavior. |
tabs.css |
Skips fades when connected tabs reserve space. |
connectedEditorTabs.css |
Removes ineffective duplicate rule. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Modern UI with connected tabs,
workbench.editor.tabActionReserveSpacedoes not affect the actual reservation of tab action space, but it does affect the tab action fade behavior.As a result, hovered, unmodified, and unpinned editor tabs can still show a faded filename even when the filename is not overlapped by the tab action button.
workbench.editor.tabActionReserveSpace: true:workbench.editor.tabActionReserveSpace: false:Fix
This change aligns the tab action fade rules with the actual tab action reservation rules. Connected tabs are now treated the same as tabs that reserve action space when deciding whether the label should fade.
It also removes a redundant CSS rule in the connected editor tabs stylesheet. That rule was no longer effective because it was overridden by a more specific selector in the main tabs stylesheet.