Support using theme icons in webview iconPath

[mjbvz]

Fixes #90616

Enables using theme icons in the webview.iconPath

This fixes the problem in a very ugly way by inlining all the codicon css classes. We should look into a proper fix

[miguelsolorio]

Is there no way to have the icons use the codicon classes then? Because we have certain icons that use certain colors/styles and will be overwritten by the file icon theme and looks odd:

[bpasero]

@mjbvz what do you want me to review here?

[mjbvz]

@bpasero I updated the change to enable codicons in tab labels:

This works but I feel we should probably push the ThemeIcons logic into the ResourceLabel class. What do you think? Any thoughts on what that change would involve?

Also @misolori, once we figure out what we want to do, I'll likely need you help tweaking some of the css.

[mjbvz]

It would be much nicer of ResourceLabel could handle this automatically

[mjbvz]

This logic is ugly and has to duplicated. We should look into pushing the icon logic into ResourceLabel

[bpasero]

@mjbvz yes, having this in resource labels seems better to me as probably most of these areas use it under the hood.

I do not fully understand what this PR is trying to solve:

• having an explicit optional icon property on editors makes sense to me and then should probably be wired in properly in those places where we show an editor
• allowing codicons as part of label or description does NOT make sense to me

I fear that escaping codicons in places like update-tabs could be a perf hit because this method may be called a ton of times. We should only change logic if the optional icon property is set on the editor input imho and should not require any escaping. The icon should just appear as part of the resource label before the text.

[miguelsolorio]

cc @aeschli if you're able to help out with this

[mjbvz]

@isidorn do you own ResourceLabel? If so, can we add this work to the April plan

[isidorn]

@mjbvz @bpasero , @jrieken and me did work in the ResourceLabel. Nobody really owns it as far as I know, so feel free to jump on it.

[jrieken]

@mjbvz For a start, there is ThemIcon.asClassName which is doing some of the CSS work for you. That's what I have used for the toolbar

[jrieken]

Generally, and swe-wise, it seems that we should have some kind of Icon-type which encapsulated all those different sources (theme icon, file icon, file icon pair for light and dark theme). A similar struggle exists with customs tree and so

[mjbvz]

I've struggled to figure out how file icons work in the workbench, especially the CSS part. Can someone please help with the workbench side of things for April?

[bpasero]

@mjbvz for file icons specifically, I would connect with @aeschli. For general label widget issues, I am mainly the author of that.

[aeschli]

We suggest we distinguish between file icons and 'product' icons.

• ResourceLabel is for file icons (and labels). The input is a resource URI and the ResourceLabel knows how how to show the associated file icon
• we need a similar helper class for product icons. Input is a product icon name (aka ThemeIcon) or a icon path (or light/dark paths).
  I'm working on the icon registry for the product icons along with a icon contribution point and theming support for all product icons. [themes] Add product icon themes #92791

@mjbvz If you want to extract what you have to a IconWidget, that would be a great starting point. Otherwise I can do this once I find time. @bpasero Please let me know if we already have something like that.

[bpasero]

@aeschli yes we do, it is called IconLabel.

We might want to reuse parts of ResourceLabels in case we expect many product icons (e.g. in trees) that are updated frequently. The idea was to remove listeners from the single resource label instance and move it to its parent.

[ghost]

What's the progress on this? Is there a reason for help-wanted on the ticket?

[vivodi]

Is this still relevant?