Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version: DG0JBJ.HDSDR version 2.81 #212831

Closed
wants to merge 1 commit into from
Closed

Update version: DG0JBJ.HDSDR version 2.81 #212831

wants to merge 1 commit into from

Conversation

Exorcism0666
Copy link
Contributor

@Exorcism0666 Exorcism0666 commented Jan 16, 2025 •
edited by microsoft-github-policy-service bot
Loading

Pull request has been created with komac v2.8.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Exorcism0666
Exorcism0666 commented Jan 16, 2025
View reviewed changes
manifests/d/DG0JBJ/HDSDR/2.81/DG0JBJ.HDSDR.installer.yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@russellbanks watch ProductCode and AppsAndFeaturesEntries, something wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot

Wait, what?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AsciiWolf I don't think I'm going to tell you anything new, but there was a conversion between UTF-8 and SHIFT_JIS (if I'm not mistaken) that went wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@russellbanks watch ProductCode and AppsAndFeaturesEntries, something wrong.

Thanks for pinging - this is fixed in komac 2.9.0 that I just released.

AsciiWolf
AsciiWolf reviewed Jan 16, 2025
View reviewed changes
manifests/d/DG0JBJ/HDSDR/2.81/DG0JBJ.HDSDR.installer.yaml
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.9.0.schema.json

PackageIdentifier: DG0JBJ.HDSDR
PackageVersion: '2.81'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the package version really still the same? It should have been 2.81a.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @stephengillie answer that question.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @ stephengillie answer that question.

I'll defer to the PR author. Please install the package in a VM or sandbox to determine its version number.

Copy link
Contributor

@AsciiWolf AsciiWolf Jan 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version in the app about dialog is 2.81a, however it is reported as 2.81 in the installed apps list.

1

2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the package version really still the same? It should have been 2.81a.

The package doesn't write a DisplayVersion entry to registry. The DisplayName is HDSDR 2.81.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 17, 2025
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 17, 2025
@AsciiWolf
Copy link
Contributor

Please do not merge yet. This needs to be fixed first.

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 17, 2025
@russellbanks russellbanks mentioned this pull request Jan 20, 2025
Merged
@russellbanks
Copy link
Contributor

Close with reason: Replaced by #214015;

auto-merge was automatically disabled January 20, 2025 21:38

Pull request was closed

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsciiWolf AsciiWolf AsciiWolf left review comments

@russellbanks russellbanks russellbanks left review comments

@stephengillie stephengillie stephengillie left review comments

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: HDSDR
5 participants
@Exorcism0666 @wingetbot @AsciiWolf @russellbanks @stephengillie