Skip to content

test optional null case for support_activation=True #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xieofxie merged 3 commits into from
Apr 13, 2026
Merged

test optional null case for support_activation=True #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63ec0d5
test null case for support_activation=True
Apr 13, 2026
d4a4235
Merge remote-tracking branch 'origin/main' into hualxie/update_for_sa…
Apr 13, 2026
5cba36c
Merge branch 'main' into hualxie/update_for_sam_qdq
xieofxie Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/winml/modelkit/pattern/op_input_gen/op_input_gen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1164,6 +1164,8 @@ def iter_qdq_combinations(
needs_weight_iteration = False

for input_name, is_constant in is_constant_map.items():
if kwargs.get(input_name) is None:
continue # Optional input not provided — nothing to QDQ-wrap, skip
if input_name not in qdq_config:
# Input not in QDQ config - skip this combination
# All inputs must be explicitly defined in qdq_config
Expand Down
5 changes: 3 additions & 2 deletions tests/unit/analyze/core/test_qdq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,8 +1106,9 @@ class TestIterQDQCombinations:
), # shape 3 * finite attributes 2 * 2 * 2 * optional combinations 2 * 2 * 2 * 4
(
"Pad",
512,
), # shape 8 * mode 4 * QDQ 4 * is_constant pads 2 * Tind 2 (actually axes not used)
1024,
), # shape 8 * mode 4 * QDQ 4 * is_constant pads 2 * constant_value present/absent 2
# * Tind 2 (axes not used)
# All Reduce* use this and it is enough
(
"ReduceSum",
Expand Down
Loading