refactor: rename EP short names to snake_case and AITK to Foundry Toolkit#373
Conversation
…lkit - Rename EP short names: directml -> dml, tensorrt/tensorrt_rtx -> nv_tensorrt_rtx - Rename WinMLCompileConfig.for_tensorrt -> for_nv_tensorrt_rtx - Rename pytest markers: directml -> dml, tensorrt -> nv_tensorrt_rtx - Drop dead classic TensorrtExecutionProvider references - Fix incorrect DirectMLExecutionProvider docstring (-> DmlExecutionProvider) - Update EP name prose (DirectML -> Dml, TensorRT -> NvTensorRTRTX in EP lists) - Rename AITK group -> Foundry Toolkit in testsets and scripts
DML support ships inside onnxruntime-windowsml on Windows; the separate onnxruntime-directml package is not the recommended install path here.
The onnxruntime-windowsml package is the single install path; pointing users at onnxruntime-gpu alongside it is redundant.
…wsml onnxruntime-windowsml is the single Windows install target covering both NPU and GPU execution providers.
|
@copilot Does this change affect the names of op json files generated by check_ops.py or the names of rules files generate by result_processor.py? |
No—this PR’s EP short-name refactor does not change |
DingmaomaoBJTU
left a comment
DingmaomaoBJTU
left a comment
There was a problem hiding this comment.
The rename is thorough — I verified the PR branch and found zero stale references for any of the renamed patterns (directml short name, tensorrt, tensorrt_rtx, for_tensorrt, AITK, onnxruntime-directml, DirectMLExecutionProvider, TensorrtExecutionProvider). The code-level changes (EP maps, factory methods, pytest markers, CLI help, session install suggestions) are all internally consistent.
One design concern below: the PR description says "DirectML stays when referring to the Microsoft product/API", but several user-facing prose contexts were changed from product names to ORT symbol names.
Thanks for the thorough check on the rename coverage. On the design concern — I don't think the three flagged locations are "product/API prose" contexts. All three are explicitly EP-symbol contexts, not product-name contexts. I'd keep these three as Dml / NvTensorRTRTX for consistency with the EP-canonical-names convention. |
…oundry-eps # Conflicts: # scripts/e2e_eval/testsets/models_all.json
- Fix absolute imports to relative: constants.py uses ..sysinfo, ep_utils.py uses ...sysinfo per CLAUDE.md import rules - Export has_rule_data_for_ep and get_devices_with_rule_data in analyze/utils/__init__.py with __all__ - Derive device probe list from _EP_DEVICE_MAP instead of hardcoded tuple, preserving NPU > GPU > CPU priority order - Rename alias trtrtx to nv_tensorrt_rtx matching codebase convention (PR #373) - Tighten test assertion from permissive 'or' to strict exit_code == 0 + called
- Fix absolute imports to relative: constants.py uses ..sysinfo, ep_utils.py uses ...sysinfo per CLAUDE.md import rules - Export has_rule_data_for_ep and get_devices_with_rule_data in analyze/utils/__init__.py with __all__ - Derive device probe list from _EP_DEVICE_MAP instead of hardcoded tuple, preserving NPU > GPU > CPU priority order - Rename alias trtrtx to nv_tensorrt_rtx matching codebase convention (PR #373) - Tighten test assertion from permissive 'or' to strict exit_code == 0 + called
…lkit (#373) Closes #372. ## Summary - Rename EP short names for consistency (snake_case, match ORT symbol casing) - `directml` → `dml` - `tensorrt` / `tensorrt_rtx` → `nv_tensorrt_rtx` - Rename `WinMLCompileConfig.for_tensorrt` → `for_nv_tensorrt_rtx` (+ dispatch table + tests) - Rename pytest markers: `directml` → `dml`, `tensorrt` → `nv_tensorrt_rtx` - Drop dead classic `TensorrtExecutionProvider` references (not supported) - Fix bug: docstring cited non-existent `DirectMLExecutionProvider` (ORT symbol is `DmlExecutionProvider`) - Prose corrections: `DirectML` → `Dml` and `TensorRT` → `NvTensorRTRTX` in EP-list contexts - Rebrand: `"group": "AITK"` → `"group": "Foundry Toolkit"` in testset JSONs, build script, README, and viewer HTML - Drop `onnxruntime-directml` references — DML is shipped inside `onnxruntime-windowsml` on Windows ## Kept intentionally - `DirectML` stays when referring to the Microsoft product/API (e.g., "Factory for DirectML compilation" docstring) - Pip package literals (real PyPI names) untouched where they are the actual install target
Closes #372.
Summary
directml→dmltensorrt/tensorrt_rtx→nv_tensorrt_rtxWinMLCompileConfig.for_tensorrt→for_nv_tensorrt_rtx(+ dispatch table + tests)directml→dml,tensorrt→nv_tensorrt_rtxTensorrtExecutionProviderreferences (not supported)DirectMLExecutionProvider(ORT symbol isDmlExecutionProvider)DirectML→DmlandTensorRT→NvTensorRTRTXin EP-list contexts"group": "AITK"→"group": "Foundry Toolkit"in testset JSONs, build script, README, and viewer HTMLonnxruntime-directmlreferences — DML is shipped insideonnxruntime-windowsmlon WindowsKept intentionally
DirectMLstays when referring to the Microsoft product/API (e.g., "Factory for DirectML compilation" docstring)