Skip to content

Fix local run qdq op.#377

Merged
chinazhangchao merged 13 commits into
mainfrom
chao/localrunqdq
May 6, 2026
Merged

Fix local run qdq op.#377
chinazhangchao merged 13 commits into
mainfrom
chao/localrunqdq

Conversation

@chinazhangchao

@chinazhangchao chinazhangchao commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

@chinazhangchao chinazhangchao changed the title fix local run qdq op Fix local run qdq op. Apr 22, 2026
@chinazhangchao chinazhangchao marked this pull request as ready for review April 29, 2026 08:05
@chinazhangchao chinazhangchao requested a review from a team as a code owner April 29, 2026 08:05
@DingmaomaoBJTU

Copy link
Copy Markdown
Collaborator

Code review

Found 1 issue:

  1. logger.warning for an expected build failure should be logger.debug — this reverses a deliberate downgrade from a prior fix. When shape inference is incomplete (common for large QDQ models), the model-build exception fires for many nodes and floods the log. The equivalent handler on main uses logger.debug.

https://github.com/microsoft/WinML-ModelKit/blob/769a7b60a481dffa976a2ab2cc010475d3315bf8/src/winml/modelkit/analyze/core/runtime_checker_query.py#L1804-L1812

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@chinazhangchao chinazhangchao merged commit ea0afef into main May 6, 2026
9 checks passed
@chinazhangchao chinazhangchao deleted the chao/localrunqdq branch May 6, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants