fix(pattern): skip ONNX validation when external data is unloaded#412
Closed
xieofxie wants to merge 1 commit into
Closed
fix(pattern): skip ONNX validation when external data is unloaded#412xieofxie wants to merge 1 commit into
xieofxie wants to merge 1 commit into
Conversation
Contributor
Author
|
See warnings like |
| from __future__ import annotations | ||
|
|
||
| import numpy as np | ||
| import onnx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_external_data=FalsecausedPatternMatcherto logWARNING Model validation failed for pattern matchingand skip all pattern detection entirely.check_onnx_modelcalledonnx.checker.check_modelon a proto whose tensors haddata_location=EXTERNALbut noraw_data; the checker couldn't find the sidecar.datafile and raisedValidationError.skip_if_unloaded_external_data: bool = Falsetocheck_onnx_model. Default isFalseso existing callers are unaffected;PatternMatcheropts in explicitly._build_lookupsskipsnumpy_helper.to_arrayfor unloaded external initializers and records their names in_external_unloaded_names._check_constant_constraintsskips the value comparison for those names so topology-based pattern matching (Gelu, LayerNorm, etc.) still works without tensor data.has_unloaded_external_datautility exported fromwinml.modelkit.onnx.tests/unit/onnx/test_onnx_utils.pyandTestPatternMatchingWithUnloadedExternalData.