Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: file grid #2564

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

feat: file grid #2564

wants to merge 37 commits into from

Conversation

gavinbarron
Copy link
Member

Closes #

PR Type

  • Feature

Description of the changes

Adds a file grid view with per item context menus to perform file actions

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Replacement for #2057

adds a new component to allow switching in the ui between light and dark modes
adds a theme toggle to all stories by default
updates developer test page to include toggle
adds helper functions to assist with theme changing using fluentui web components theming tools
adds a file grid option to the file-list-composite
@gavinbarron gavinbarron requested a review from a team as a code owner June 27, 2023 16:26
@ghost
Copy link

ghost commented Jun 27, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@eduardpaul
Copy link

Wow really was looking for something like this. Hope to se it soon in main branch.

@sebastienlevert
Copy link
Contributor

If you want to help and complete the PR, we'd gladly provide support to bring this feature across the finish line!

Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
8.4% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants