Skip to content

extraConfig and extraArgs for firecracker #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

extraConfig and extraArgs for firecracker #434

wants to merge 2 commits into from

Conversation

@bjackman
Copy link
Contributor

@bjackman bjackman commented Nov 18, 2025 •
edited
Loading 

❯❯  git log -n 2
commit 2c0e70ee0c7d36902e6f2fd6d523dedfb5e51846 (HEAD -> firecracker-extraconfig, fork/firecracker-extraconfig)
Author: Brendan Jackman <[email protected]>
Date:   Mon Nov 10 15:20:49 2025 +0000

    fireracker: Add extraArgs option
    
    For experimentation, support adding arbitrary extra args.

commit b6c5f9c5008463f0769e4c6b70aa0a26c98c9fbb
Author: Brendan Jackman <[email protected]>
Date:   Fri Nov 7 13:42:11 2025 +0000

    firecracker: Add extraConfig option
    
    For experimentation with low-level settings, add support for merging in
    arbitrary options to the Firecracker config file, following the standard pattern
    in nixpkgs for this kind of thing.
    
    My immediate usecase for this is for experimenting with firecracker features
    that are not yet released, so it doesn't make sense to add more specific Nix
    options for those features.

@bjackman
firecracker: Add extraConfig option
b6c5f9c 
For experimentation with low-level settings, add support for merging in
arbitrary options to the Firecracker config file, following the standard pattern
in nixpkgs for this kind of thing.

My immediate usecase for this is for experimenting with firecracker features
that are not yet released, so it doesn't make sense to add more specific Nix
options for those features.
@bjackman
fireracker: Add extraArgs option
2c0e70e 
For experimentation, support adding arbitrary extra args.
@bjackman bjackman changed the title Firecracker extraconfig extraConfig and extraArgs for firecracker Nov 18, 2025
SuperSandro2000
SuperSandro2000 requested changes Nov 23, 2025
View reviewed changes
nixos-modules/microvm/options.nix
};

firecracker.extraConfig = mkOption {
type = types.attrs;
Copy link
Member

@SuperSandro2000 SuperSandro2000 Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That type does not merge. We need to use a submodule of attrs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bjackman @SuperSandro2000