feat: upgrade template to runtime v0.15.0#28
feat: upgrade template to runtime v0.15.0#28tusharpamnani wants to merge 5 commits intomidnightntwrk:mainfrom
Conversation
|
Hey, thanks for the updated PR! This is a big improvement over the first one; the source files are properly updated this time, and the new SDK patterns (WalletFacade.init, signRecipe, waitForSyncedState) all check out. A few things before we can merge:
On the Minor: There's a pre-existing TS error on Overall, this is looking close, just these tweaks, and it should be good to go! |
|
hey @Olanetsoft, I've updated the code according to the requested changes. |
Olanetsoft
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround on the fixes! Everything checks out — approving and merging.
|
@tusharpamnani I'm not able to merge; please sign your commits. |
|
hey @Olanetsoft, just pushed a signed commit (added a small whitespace change). It should be good to merge now! |
|
@tusharpamnani i still can't get this merged. can you do And then to re-sign all commits: Then: You should be all good! |
|
hey @Olanetsoft, all commits have been re-signed and the branch is updated. This should be good to merge now |
|
Hey Tushar! The PR is approved and looking great, but GitHub is still blocking the merge because the commit signatures aren't showing as verified. A couple of things to check:
Once that's sorted, do the rebase and force push again: git rebase --exec 'git commit --amend --no-edit -S' origin/main After pushing, check on GitHub that each commit shows a green "Verified" badge. If they don't, the key/email mismatch is usually the culprit. Let me know if you run into any issues! @tusharpamnani |
|
Hey @Olanetsoft , just pushed a fix for the signature issue. Turned out the problem was a mix of unsigned commits + my old GPG key being unusable, so I generated a new key, configured Git properly, and re-signed everything. Just verified locally as well — latest commit shows: You should now see the green Verified badge on GitHub. Let me know if it's all good from your side! |
|
@tusharpamnani, unfortunately, we’re facing the same problem. It’s frustrating despite all the fixes, so we might have to close this PR. Please open a new one with the same code but use a signed commit. That way, we'll have a single signed commit for the code, and I can approve it. |
Description
This PR upgrades the
hello-worldtemplate to utilize Midnight SDK v8 (runtimev0.15.0). It refactors the core wallet and provider logic to align with the latest architectural patterns, including the new asynchronousWalletFacadeinitialization and the mandatory encrypted private state provider.Type of Change
Related Issues
Related to # Runtime compatibility upgrade
Motivation and Context
The Midnight SDK has introduced significant breaking changes in
v8, most notably the transition toledger-v8and the requirement for encrypted local storage for the level private state provider. This update ensures that new projects created withcreate-mn-appare compatible with the latest network requirements and security best practices.Changes Made
@midnight-ntwrk/ledger-v8.WalletFacadeconstructor with the newWalletFacade.initpattern.signRecipemethodology, replacing the previous manual intent-signing workaround.PRIVATE_STATE_PASSWORDenvironment variable.wallet.waitForSyncedState()intodeploy,cli, andcheck-balancefor more reliable network synchronization.READMEto guide users through the new environment variable requirements.Testing Performed
Manual Testing
Test Commands
Breaking Changes
Note: Projects generated with this version will require
PRIVATE_STATE_PASSWORDto be set in the environment or an error will be thrown during script execution.Documentation
Checklist
Code Quality