feat: add assetsPath prop to enhance assets path configuration #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mifi
reviewed
Jan 31, 2025
| @@ -28,7 +28,7 @@ declare module 'react-lottie-player' { | |||
|
|
|||
| /** Lottie `AnimationItem` Instance */ | |||
| ref?: React.Ref<AnimationItem | undefined> | |||
| } & ({ path?: string } | { animationData?: { ['default']: object } | object }) | |||
| } & ({ path?: string } | { assetsPath?: string } | { animationData?: { ['default']: object } | object }) | |||
There was a problem hiding this comment.
Not sure if this is correct typing. Doesnt this mean that you cannot specify both assetPath and path/animationData together? Is that intented?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added a props called "assetsPath" to enhance assets path configuration
Thanks in advance and do not hesitate to contact me if needed :)
See you, and thanks again for your library ;)