Fix extension failure #273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arath17
force-pushed
the
fix-extension-failure
branch
from
d18e76e to
5f158ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#169
Expiration time of the lock is calculated by adding duration of lock on start time but start time in the code is the time when acquiring of lock is attempted for the first time. Expiration time becomes too early, hence causing the failure in extension of locks.
@mike-marcacci I saw PR: #167 where you've mentioned that the expiration time should be same or early than the one in redis. This PR will keep lock's expiration time as close to the redis expiration but never later