fix: Potential fix (and potential bugs) #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikew
commented
Sep 4, 2024
Comment on lines
+202
to
+206
| -- ... or if we do have a window but don't have a buffer, we use the buffer | ||
| -- of the window. | ||
| if winid ~= -1 and bufnr == -1 then | ||
| bufnr = vim.api.nvim_win_get_buf(winid) | ||
| end |
There was a problem hiding this comment.
This feels "technically correct": when .open is called, and somehow there is a window that belongs to the drawer but it doesn't contain a known buffer, that buffer is used.
The controversial / potential bugs bit is the fact that it happens after the logic for should_reuse_previous_bufnr happens, and that logic very intentionally defaults back to -1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.