-
Notifications
You must be signed in to change notification settings - Fork 3.2k
feat: impl StructArray -- data storage support in segcore #42406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: impl StructArray -- data storage support in segcore #42406
Conversation
…orField Signed-off-by: SpadeA <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA <[email protected]>
Signed-off-by: SpadeA <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SpadeA-Tang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
Signed-off-by: SpadeA <[email protected]>
@SpadeA-Tang go-sdk check failed, comment |
@SpadeA-Tang E2e jenkins job failed, comment |
@SpadeA-Tang cpp-unit-test check failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project check has failed because the head coverage (72.96%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #42406 +/- ##
=======================================
Coverage 72.96% 72.96%
=======================================
Files 335 335
Lines 30988 30988
=======================================
Hits 22610 22610
Misses 8378 8378
🚀 New features to boost your workflow:
|
Signed-off-by: SpadeA <[email protected]>
@SpadeA-Tang go-sdk check failed, comment |
@SpadeA-Tang E2e jenkins job failed, comment |
@SpadeA-Tang cpp-unit-test check failed, comment |
Ref #42148
This PR mainly enables segcore to support array of vector (read and write, but not indexing). Now only float vector as the element type is supported.