-
Notifications
You must be signed in to change notification settings - Fork 3.2k
enhance: [2.5] Remove balance constraints between channel and segment tasks #42410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: [2.5] Remove balance constraints between channel and segment tasks #42410
Conversation
Remove the mutual exclusion constraints between channel and segment balance tasks to allow them to run concurrently. Changes include: - Remove permitBalanceChannel() and permitBalanceSegment() methods from RoundRobinBalancer - Update ChannelLevelScoreBalancer, MultiTargetBalancer, RowCountBasedBalancer, and ScoreBasedBalancer to remove constraint checks - Allow segment balance tasks to proceed even when channel balance tasks are running - Update test cases to reflect new behavior where balance tasks no longer block each other - Improve error handling in task executor by preferring serviceable shard leaders for segment release operations - Add fallback logic to find latest shard leader when serviceable leader is not available This change improves the efficiency of load balancing by removing unnecessary coordination overhead between different types of balance operations. Signed-off-by: Wei Liu <[email protected]>
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #42410 +/- ##
==========================================
- Coverage 80.68% 80.64% -0.04%
==========================================
Files 1428 1428
Lines 205836 205829 -7
==========================================
- Hits 166069 165991 -78
- Misses 33927 33999 +72
+ Partials 5840 5839 -1
🚀 New features to boost your workflow:
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weiliu1031, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #42176
pr: #42177
Remove the mutual exclusion constraints between channel and segment balance tasks to allow them to run concurrently.
Changes include:
This change improves the efficiency of load balancing by removing unnecessary coordination overhead between different types of balance operations.
Signed-off-by: Wei Liu [email protected]