Skip to content

fix: Bump milvus-common to fix tracer link error - #50932

Closed
jamesgao-jpg wants to merge 1 commit into
milvus-io:masterfrom
jamesgao-jpg:fix/milvus-common-3039f35
Closed

fix: Bump milvus-common to fix tracer link error#50932
jamesgao-jpg wants to merge 1 commit into
milvus-io:masterfrom
jamesgao-jpg:fix/milvus-common-3039f35

Conversation

@jamesgao-jpg

@jamesgao-jpg jamesgao-jpg commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Bump milvus-common from the current master pin 1.0.0-835fcd0 to 1.0.0-a3299ca.
  • Use the published Conan recipe revision eea0e22b8d5e36ff6f0a5ffbed14703e.
  • Fix the tracer AutoSpan link error caused by the OpenTelemetry ABI namespace mismatch.

PR #50733 moved Milvus master from the original bad milvus-common/1.0.0-4f41e32 package to 1.0.0-835fcd0, but that package is still before the tracing-symbol fix. PR zilliztech/milvus-common#101 fixes the milvus-common header forward declaration for OpenTelemetry ABI namespaces. PR zilliztech/milvus-common#103 adds later trace-helper overloads, and PR milvus-io/conanfiles#155 publishes the resulting milvus-common/1.0.0-a3299ca@milvus/dev Conan recipe used by this PR.

Fixes #50861

Tests

  • git diff --check
  • python3 -m py_compile internal/core/conanfile.py

Cloud/Jenkins owns full validation after the latest push. No local full Milvus build was rerun for the latest 1.0.0-a3299ca pin.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 30, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jamesgao-jpg
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify Bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 30, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-code-check-macos // for Code Checker MacOS (GitHub Actions)
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
  • /ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images; update .env after the new tag is ready)
  • /ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
  • /ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
  • /ci-rerun-e2e-default // for ci-v2/e2e-default
  • /ci-rerun-e2e-amd // for ci-v2/e2e-amd (e2e pool dispatcher)
  • /ci-rerun-build-ut-cov // for ci-v2/build-ut-cov (build + unit tests in one pipeline)
  • /ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, ARM)

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot

Copy link
Copy Markdown
Contributor

✅ CI Loop Results 34466f5

Stage Result Duration Tests
✅ Build SUCCESS 16.1min -
✅ Code-Check SUCCESS 8.6min -
✅ UT-GO SUCCESS 21.8min 1071 total, 1071 passed, 0 failed
✅ UT-Integration SUCCESS 25.1min 46 total, 46 passed, 0 failed
✅ UT-CPP-Cov SUCCESS 62.2min 8041 total, 8041 passed, 0 failed

Total: 84min | Pipeline | Artifacts

Overall Coverage: 63.1%

@sre-ci-robot sre-ci-robot added the low-code-coverage add test-label from zhikun, diff coverage > 80% label Jun 30, 2026
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.37%. Comparing base (182134e) to head (84ce053).
⚠️ Report is 11 commits behind head on master.

⚠️ Current head 84ce053 differs from pull request most recent head 1d481b9

Please upload reports for the commit 1d481b9 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #50932      +/-   ##
==========================================
- Coverage   79.40%   79.37%   -0.03%     
==========================================
  Files        2290     2282       -8     
  Lines      418441   415974    -2467     
==========================================
- Hits       332259   330180    -2079     
+ Misses      75981    75659     -322     
+ Partials    10201    10135      -66     
Components Coverage Δ
Client 80.65% <ø> (-0.22%) ⬇️
Core 86.53% <ø> (+0.03%) ⬆️
Go 76.99% <ø> (-0.06%) ⬇️
see 132 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamesgao-jpg
jamesgao-jpg force-pushed the fix/milvus-common-3039f35 branch from 34466f5 to 84ce053 Compare June 30, 2026 11:01
@sre-ci-robot sre-ci-robot removed the low-code-coverage add test-label from zhikun, diff coverage > 80% label Jun 30, 2026
@sre-ci-robot

Copy link
Copy Markdown
Contributor

✅ CI Loop Results 84ce053

Stage Result Duration Tests
✅ Build SUCCESS 16.1min -
✅ Code-Check SUCCESS 9.0min -
✅ UT-Integration SUCCESS 24.9min 46 total, 46 passed, 0 failed
✅ UT-GO SUCCESS 21.2min 1071 total, 1071 passed, 0 failed
✅ UT-CPP-Cov SUCCESS 61.0min 8047 total, 8047 passed, 0 failed

Total: 83min | Pipeline | Artifacts

Overall Coverage: 72.2%

@sre-ci-robot sre-ci-robot added the low-code-coverage add test-label from zhikun, diff coverage > 80% label Jun 30, 2026
@jamesgao-jpg
jamesgao-jpg force-pushed the fix/milvus-common-3039f35 branch from 84ce053 to 3adab20 Compare July 1, 2026 14:19
@sre-ci-robot

Copy link
Copy Markdown
Contributor

✅ CI Loop Results 3adab20

Stage Result Duration Tests
✅ Build SUCCESS 14.6min -
✅ Code-Check SUCCESS 7.4min -
✅ UT-Integration SUCCESS 25.1min 46 total, 46 passed, 0 failed
✅ UT-GO SUCCESS 22.5min 1081 total, 1081 passed, 0 failed
✅ UT-CPP-Cov SUCCESS 60.8min 8052 total, 8052 passed, 0 failed

Total: 81min | Pipeline | Artifacts

Overall Coverage: 72.3%

@jamesgao-jpg
jamesgao-jpg force-pushed the fix/milvus-common-3039f35 branch from 3adab20 to 6297fff Compare July 2, 2026 03:56
@sre-ci-robot

Copy link
Copy Markdown
Contributor

✅ CI Loop Results 6297fff

Stage Result Duration Tests
✅ Build SUCCESS 14.6min -
✅ Code-Check SUCCESS 7.5min -
✅ UT-Integration SUCCESS 24.8min 46 total, 46 passed, 0 failed
✅ UT-GO SUCCESS 20.3min 1081 total, 1081 passed, 0 failed
✅ UT-CPP-Cov SUCCESS 62.2min 8053 total, 8053 passed, 0 failed

Total: 83min | Pipeline | Artifacts

Overall Coverage: 72.2%

@jamesgao-jpg
jamesgao-jpg force-pushed the fix/milvus-common-3039f35 branch from 6297fff to 9b8e5b6 Compare July 2, 2026 08:02
@sre-ci-robot

Copy link
Copy Markdown
Contributor

✅ CI Loop Results 9b8e5b6

Stage Result Duration Tests
✅ Build SUCCESS 16.1min -
✅ Code-Check SUCCESS 10.2min -
✅ UT-Integration SUCCESS 24.9min 46 total, 46 passed, 0 failed
✅ UT-GO SUCCESS 22.4min 1087 total, 1087 passed, 0 failed
✅ UT-CPP-Cov SUCCESS 62.9min 8053 total, 8053 passed, 0 failed

Total: 85min | Pipeline | Artifacts

Overall Coverage: 72.3%

@mergify mergify Bot added the ci-passed label Jul 2, 2026
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
@sre-ci-robot

Copy link
Copy Markdown
Contributor

✅ CI Loop Results 1d481b9

Stage Result Duration Tests
✅ Build SUCCESS 16.4min -
✅ Code-Check SUCCESS 11.2min -
✅ UT-Integration SUCCESS 25.3min 46 total, 46 passed, 0 failed
✅ UT-GO SUCCESS 22.5min 1087 total, 1087 passed, 0 failed
✅ UT-CPP-Cov SUCCESS 63.6min 8053 total, 8053 passed, 0 failed

Total: 88min | Pipeline | Artifacts

Overall Coverage: 72.2%

@jamesgao-jpg

Copy link
Copy Markdown
Contributor Author

/ci-rerun-e2e-default

@mergify mergify Bot added the ci-passed label Jul 3, 2026
@jamesgao-jpg

Copy link
Copy Markdown
Contributor Author

Closing this PR as superseded by PR #50606, which has merged and already carries the same milvus-common Conan pin (milvus-common/1.0.0-a3299ca@milvus/dev#eea0e22b8d5e36ff6f0a5ffbed14703e).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug low-code-coverage add test-label from zhikun, diff coverage > 80% size/XS Denotes a PR that changes 0-9 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: linkage error for tracer::AutoSpan on MacOS platform

2 participants