fix: Bump milvus-common to fix tracer link error - #50932
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jamesgao-jpg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
✅ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 16.1min | - |
| ✅ Code-Check | SUCCESS | 8.6min | - |
| ✅ UT-GO | SUCCESS | 21.8min | 1071 total, 1071 passed, 0 failed |
| ✅ UT-Integration | SUCCESS | 25.1min | 46 total, 46 passed, 0 failed |
| ✅ UT-CPP-Cov | SUCCESS | 62.2min | 8041 total, 8041 passed, 0 failed |
Total: 84min | Pipeline | Artifacts
Overall Coverage: 63.1%
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 1d481b9 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## master #50932 +/- ##
==========================================
- Coverage 79.40% 79.37% -0.03%
==========================================
Files 2290 2282 -8
Lines 418441 415974 -2467
==========================================
- Hits 332259 330180 -2079
+ Misses 75981 75659 -322
+ Partials 10201 10135 -66
🚀 New features to boost your workflow:
|
34466f5 to
84ce053
Compare
✅ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 16.1min | - |
| ✅ Code-Check | SUCCESS | 9.0min | - |
| ✅ UT-Integration | SUCCESS | 24.9min | 46 total, 46 passed, 0 failed |
| ✅ UT-GO | SUCCESS | 21.2min | 1071 total, 1071 passed, 0 failed |
| ✅ UT-CPP-Cov | SUCCESS | 61.0min | 8047 total, 8047 passed, 0 failed |
Total: 83min | Pipeline | Artifacts
Overall Coverage: 72.2%
84ce053 to
3adab20
Compare
✅ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 14.6min | - |
| ✅ Code-Check | SUCCESS | 7.4min | - |
| ✅ UT-Integration | SUCCESS | 25.1min | 46 total, 46 passed, 0 failed |
| ✅ UT-GO | SUCCESS | 22.5min | 1081 total, 1081 passed, 0 failed |
| ✅ UT-CPP-Cov | SUCCESS | 60.8min | 8052 total, 8052 passed, 0 failed |
Total: 81min | Pipeline | Artifacts
Overall Coverage: 72.3%
3adab20 to
6297fff
Compare
✅ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 14.6min | - |
| ✅ Code-Check | SUCCESS | 7.5min | - |
| ✅ UT-Integration | SUCCESS | 24.8min | 46 total, 46 passed, 0 failed |
| ✅ UT-GO | SUCCESS | 20.3min | 1081 total, 1081 passed, 0 failed |
| ✅ UT-CPP-Cov | SUCCESS | 62.2min | 8053 total, 8053 passed, 0 failed |
Total: 83min | Pipeline | Artifacts
Overall Coverage: 72.2%
6297fff to
9b8e5b6
Compare
✅ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 16.1min | - |
| ✅ Code-Check | SUCCESS | 10.2min | - |
| ✅ UT-Integration | SUCCESS | 24.9min | 46 total, 46 passed, 0 failed |
| ✅ UT-GO | SUCCESS | 22.4min | 1087 total, 1087 passed, 0 failed |
| ✅ UT-CPP-Cov | SUCCESS | 62.9min | 8053 total, 8053 passed, 0 failed |
Total: 85min | Pipeline | Artifacts
Overall Coverage: 72.3%
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
9b8e5b6 to
1d481b9
Compare
✅ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 16.4min | - |
| ✅ Code-Check | SUCCESS | 11.2min | - |
| ✅ UT-Integration | SUCCESS | 25.3min | 46 total, 46 passed, 0 failed |
| ✅ UT-GO | SUCCESS | 22.5min | 1087 total, 1087 passed, 0 failed |
| ✅ UT-CPP-Cov | SUCCESS | 63.6min | 8053 total, 8053 passed, 0 failed |
Total: 88min | Pipeline | Artifacts
Overall Coverage: 72.2%
|
/ci-rerun-e2e-default |
|
Closing this PR as superseded by PR #50606, which has merged and already carries the same milvus-common Conan pin ( |
Summary
milvus-commonfrom the current master pin1.0.0-835fcd0to1.0.0-a3299ca.eea0e22b8d5e36ff6f0a5ffbed14703e.AutoSpanlink error caused by the OpenTelemetry ABI namespace mismatch.PR #50733 moved Milvus master from the original bad
milvus-common/1.0.0-4f41e32package to1.0.0-835fcd0, but that package is still before the tracing-symbol fix. PR zilliztech/milvus-common#101 fixes themilvus-commonheader forward declaration for OpenTelemetry ABI namespaces. PR zilliztech/milvus-common#103 adds later trace-helper overloads, and PR milvus-io/conanfiles#155 publishes the resultingmilvus-common/1.0.0-a3299ca@milvus/devConan recipe used by this PR.Fixes #50861
Tests
git diff --checkpython3 -m py_compile internal/core/conanfile.pyCloud/Jenkins owns full validation after the latest push. No local full Milvus build was rerun for the latest
1.0.0-a3299capin.