[DOC] fix notation inconsistencies #552
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the-user-guide-section-3
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
=======================================
Coverage 98.37% 98.37%
=======================================
Files 23 23
Lines 1602 1602
=======================================
Hits 1576 1576
Misses 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bthirion
reviewed
Dec 8, 2025
Collaborator
bthirion
left a comment
bthirion
left a comment
There was a problem hiding this comment.
One suggestion of improvement on notations
docs/src/glossary_and_notations.rst
Outdated
| are shuffled across samples, independently from the other features. | ||
|
|
||
| conditional permutation of a feature | ||
| :math:`\tilde X^{(j)}` |
Collaborator
There was a problem hiding this comment.
wondering whether :math:X^{\pi (j|-j)} wouldn't be clearer then ?
Collaborator
There was a problem hiding this comment.
Additionally, it would make this different from the knockoff notation. In principle, these are different things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.