-
Notifications
You must be signed in to change notification settings - Fork 15
feat: CodeGroup component #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
17f271f
copy in codegroup components and lint
lawreka 49ac992
clean up props and ts error
lawreka 4fa7c64
address bugbot comments
lawreka 386fa93
address bugbot comments and fix dropdown background colors
lawreka 37e2900
bounds check initial index and fix tailwind selectors
lawreka 30eedf9
Merge branch 'main' of https://github.com/mintlify/components into ka…
lawreka 8529777
migrate radix usage to base-ui
lawreka 051b2bf
clean comments
lawreka 7e95ec6
fix fallback and potential memory leak issues
lawreka 2cea3b6
fix bad tailwind selector and duplicate data-test-id
lawreka 06848e9
Merge branch 'main' of https://github.com/mintlify/components into ka…
lawreka aa894cc
Update packages/components/src/components/code-group/code-group-selec…
lawreka 4228f5f
Update packages/components/src/components/code-group/code-group.tsx
lawreka e2c2139
Update packages/components/src/components/code-group/code-select-drop…
lawreka 3d5a179
Update packages/components/src/components/code-group/code-snippet.tsx
lawreka 6bc0157
lint and fix interface to type typo
lawreka 92bdece
add TabItemProps
lawreka a328b3a
LanguageIconProps
lawreka 6798042
centralize codeBlockTheme prop in validaiton
lawreka f566c72
remove unused select component, clean up passing of copy button props…
lawreka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copyButtonProps type requires textToCopy, overrides computed value
Medium Severity
The
copyButtonPropsprop has typeCopyToClipboardButtonPropswhich requirestextToCopy: string. Since the component computestextToCopyinternally and spreadscopyButtonPropsafter the explicit prop, users face two problems: TypeScript errors when passing justonCopiedwithouttextToCopy, and unintentional override of the computed text when they do providetextToCopy. The type should likely beOmit<CopyToClipboardButtonProps, 'textToCopy'>to allow passing callbacks without forcing atextToCopyvalue.Additional Locations (1)
packages/components/src/components/code-group/code-group.tsx#L39-L40